2012730 - The Graph extract crate does not create imports when the type is custom but not a direct ref

Status: RESOLVED FIXED

(MailNews Core :: Networking: Exchange, defect)

Comment 1

[Brendan Abolivier [:babolivier]]

Attachment: Bug 2012730 - Create imports for custom Graph types even it they're not a direct ref. r=#thunderbird-back-end-reviewers

Which it turns out is essentially what D279798 was proposing initially (in a
slightly different way).

I'm also including the ItemBody type as an example (since that's a type that
didn't get properly imported before this change).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bcee52fba79c
Create imports for custom Graph types even it they're not a direct ref. r=jtracey

Comment 3

[Eleanor Dicharry]

Attachment: Bug 2012730 - follow-up: Fix formatting for updated Rust edition. r=#thunderbird-reviewers

Comment 4

[Eleanor Dicharry]

We picked up a rust formatting error from this one: https://treeherder.mozilla.org/jobs?repo=comm-central&revision=bcee52fba79c511a4ee3ea531997c30182a8edc4&selectedTaskRun=Jpp0GvBNSRCxatANw197aA.0

Brendan - can you submit a follow-up patch to correct the formatting? I tried doing it myself, but it wound up changing generated code, so I think we need to update the code generator for the new formatting rules we got with Rust 2024 and regenerate.

Comment 5

[Eleanor Dicharry]

Nevermind - I read the README and realized the generated code just needs to be formatted like normal, so I submitted a follow-up patch for that.

Comment 6

[Eleanor Dicharry]

Attachment: Bug 2012730 - follow-up: Fix formatting for updated Rust edition. r=#thunderbird-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/310dc8aa5f1f
follow-up: Fix formatting for updated Rust edition. r=jtracey

Comment 8

[Brendan Abolivier [:babolivier]]

Bah, sorry about that 🙁

Thanks for fixing!