2038467 - Typing gets repeated when entering text 2 characters after @ in email fields

Status: VERIFIED FIXED

(GeckoView :: IME, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

Steps to reproduce

1. Go to any site with a login page with an email-entry field
2. Type an email address. Two characters after typing '@' the contents of the field will get inserted at the local position.
   example:
   type ffgh@1 -> field reads ffgh@1
   type '2' -> field reads ffgh@ffgh121 with the cursor after the 2

Device information

Samsung S20FE

• Firefox version: 150.0.1
• Android device model: Samsung Galaxy S20FE
• Android OS version: 13

Note: this only happens on one of our phones. No extensions.

Profile: https://share.firefox.dev/4nmJysT

Comment 1

[Makoto Kato [:m_kato]]

Is your keyboard Samsung keyboard? Although I try to reproduce on Galaxy S20 (JP) / Android 13 with Samsung keyboard (5.6.10.48), I cannot reproduce this by https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/input/email

Comment 2

[Makoto Kato [:m_kato]]

Also, if you take a profiler data by Firefox Nightly, I would like to request that moz log module is IMEHandler:5 by about:logging. If text transaction doesn't wok on Gecko side, not Java side, we may be able to find it.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

I can try that. Not sure if it was samsung or gboard (probably default, which is likely samsung, but I'll check - daughter's phone)

Comment 4

[Makoto Kato [:m_kato]]

Thank you, I can reproduce this now on Nightly + Samsung keyboard. Probably this is a regression by bug 2012938

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 2012938

Comment 6

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/jobs?repo=try&revision=4ac64c5e3a4bae0c5a7d2e44a235d29db8c8a6a3

Comment 7

[Makoto Kato [:m_kato]]

Attachment: Bug 2038467 - Don't sync shadow text by setComposingRegion. r=#geckoview-reviewers!

This is a regression by bug 2012938.

Android IME (InputConnection) often requests current editable text
by synchronous. But Gecko has its on content process, so we have two
data for Java side (ShadowText) and content side (CurrentText). This
is synchronous when Gecko notifies IME of text/selection changes.

After bug 2012938 fix, it doesn't notify Gecko of IME composing range
during batch mode to avoid unnecessary selection changes. After ending
batch mode, we will send current composing ranges. Without text changes,
IME content observer doesn't notify widget of any changes. So calling
onIMESynchronized causes unexpected text/selection changes. Then text
transaction is broken.

So we shouldn't call it and not sync shadow text on ending batch mode.

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Can we get a fix out for this and uplift to beta?
Also: are there any workarounds?

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 2012938

Comment 10

[Makoto Kato [:m_kato]]

(In reply to Randell Jesup [:jesup] (needinfo me) from comment #8)

Can we get a fix out for this and uplift to beta?

Yes, after landing this, I will request uplift.

Also: are there any workarounds?

This is a timing issue, If you use Samsung keyboard, disabling some "smart typing" features in Samsung Keyboard settings might be workaround.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6300d710cc49
https://hg.mozilla.org/integration/autoland/rev/6d9381770c7b
Don't sync shadow text by setComposingRegion. r=geckoview-reviewers,tcampbell

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6d9381770c7b

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:m_kato, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox152 to wontfix.

For more information, please visit BugBot documentation.

Comment 14

[Donal Meehan [:dmeehan]]

To add to comment 13, please also include a release uplift request. Depending on the risk, we should include this in a Fx151 dot release.

Comment 15

[Makoto Kato [:m_kato]]

Attachment: Bug 2038467 - Don't sync shadow text by setComposingRegion.

This is a regression by bug 2012938.

Android IME (InputConnection) often requests current editable text
by synchronous. But Gecko has its on content process, so we have two
data for Java side (ShadowText) and content side (CurrentText). This
is synchronous when Gecko notifies IME of text/selection changes.

After bug 2012938 fix, it doesn't notify Gecko of IME composing range
during batch mode to avoid unnecessary selection changes. After ending
batch mode, we will send current composing ranges. Without text changes,
IME content observer doesn't notify widget of any changes. So calling
onIMESynchronized causes unexpected text/selection changes. Then text
transaction is broken.

So we shouldn't call it and not sync shadow text on ending batch mode.

Original Revision: https://phabricator.services.mozilla.com/D300235

Comment 16

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: When inputting any string on Samsung Keyboard, inputting text may be corrupted such as text is duplicated.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: This is a regression by bug 2012938. This fix removes unnecessary code to sync android's text.
• String changes made/needed?: No
• Is Android affected?: yes

Comment 17

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: When inputting any string on Samsung Keyboard, inputting text may be corrupted such as text is duplicated.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: This is a regression by bug 2012938. This fix removes unnecessary code to sync android's text.
• String changes made/needed?: No
• Is Android affected?: yes

Comment 18

[Makoto Kato [:m_kato]]

Attachment: Bug 2038467 - Don't sync shadow text by setComposingRegion.

This is a regression by bug 2012938.

Android IME (InputConnection) often requests current editable text
by synchronous. But Gecko has its on content process, so we have two
data for Java side (ShadowText) and content side (CurrentText). This
is synchronous when Gecko notifies IME of text/selection changes.

After bug 2012938 fix, it doesn't notify Gecko of IME composing range
during batch mode to avoid unnecessary selection changes. After ending
batch mode, we will send current composing ranges. Without text changes,
IME content observer doesn't notify widget of any changes. So calling
onIMESynchronized causes unexpected text/selection changes. Then text
transaction is broken.

So we shouldn't call it and not sync shadow text on ending batch mode.

Original Revision: https://phabricator.services.mozilla.com/D300235

Comment 19

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/f77394d89ce7
https://hg.mozilla.org/releases/mozilla-beta/rev/dc69b2b0e7d6

Comment 20

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: Recording_20260613_132632.mp4

This issue is verified as fixed on Firefox for Android Nightly 153 (2026-05-27) and Firefox 152 beta 4 under Samsung S24 Ultra (Android 16) and Huawei MediaPad T5 (Android 8). Confirming that the signin flow works without issues on the top 10 most visited sites.

Comment 21

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/9e42ffc82bbf
https://hg.mozilla.org/releases/mozilla-release/rev/cd667a671072

Comment 23

[Adina Petridean QA [:apetridean]]

Verified as fixed on Firefox RC 151.0.3 with Asus Zenfone 9 ( Android 13) and Lenovo Yoga Tab 11 (Android 12).