2013014 - Populate boolean pref when running in Snap or Flatpak

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Toby Pilling [:tobyp]]

Find a simple way to detect profiles running in Snap or Flatpak so that we can target users via in-app notification to notify them about changes planned to the default version packaged.

Although we have a Native solution with IsRunningUnderFlatpakOrSnap() here: https://searchfox.org/comm-central/source/mozilla/widget/gtk/WidgetUtilsGtk.h#49, we can implement a simpler approach using something like this:

Services.env.exists("FLATPAK_ID") ||
Services.env.exists("SNAP") ||
Services.env.exists("SNAP_NAME")

AND/OR looking for "snap" or "flatpak" in:

Services.prefs
.getDefaultBranch("")
.getCharPref("distribution.id", "")

Comment 1

[Toby Pilling [:tobyp]]

Attachment: Bug 2013014 - Populate boolean pref when running in Snap or Flatpak. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/549e2fd5cb44
Populate boolean pref when running in Snap or Flatpak. r=arschmitz,mkmelin

Comment 3

[Toby Pilling [:tobyp]]

Comment on attachment 9540729 [details]
Bug 2013014 - Populate boolean pref when running in Snap or Flatpak. r=#thunderbird-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: We'll need this in advance to notify users about Snap & Flatpak changes
• User impact if declined: We won't be able to use in-app notifications to warn users and there will be more complaints and support tickets
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: Yes
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just a pref that gets set under specific circumstances
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: None

Comment 4

[Corey Bryant]

Comment on attachment 9540729 [details]
Bug 2013014 - Populate boolean pref when running in Snap or Flatpak. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr140

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 140.8.1esr:
https://hg.mozilla.org/releases/comm-esr140/rev/05c9e764534b