2013044 - trust panel: "connection secure" displayed alongside insecure icon on sites with added security exception

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Manuel Bucher [:manuel]]

Attachment: grid.png

STR:

1. Go to https://self-signed.badssl.com/
2. Accept the risk
3. open shield icon

Got result: "Connection Secure" is displayed alongside insecure lock icon
Expected result: "Connection not secure" is displayed alongside insecure lock icon

With bug 2010045 the lock icon changed from the secure one to the insecure one. However, I'd also expected the "Connection not secure" text besides it (and it looks like it was also expected when glancing at the commit). I wasn't sure whether to open a new bug or reopen the other one. Feel free to change my decision in post.

attaching a screenshot grid with:

new design on error page	new design after accepted risk
old design on error page	old design after accepted risk

Comment 1

[Manuel Bucher [:manuel]]

Attachment: connection-not-secure.png

After taking a close look at the commit, it might have been the intended change? However, when clicking on the "connection secure" label, you get to the next menu, which contradics it with stating "connection not secure". And the state of the lock icon seems somewhat off? Is there a design document about how error states should be displayed?

Comment 2

[Moritz Beier [:mbeier]]

Hey Dale, could you please have a look at this?

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: Bug 2013044 - Fix page status when certificate overridden. r=daisuke

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/eb904105080d
https://hg.mozilla.org/integration/autoland/rev/71c701986a0f
Fix page status when certificate overridden. r=daisuke,urlbar-reviewers

Comment 7

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/71c701986a0f