201309 - "Too many network errors" caused by too many left over ns_tempX dirs

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Sean Su]

When there's too many (~9 - ~10) ns_tempX dirs, the native windows installer
gives a "Too many network errors" error message.

The problem with this might be caused by bug 190816 (mozilla fails to shutdown
completely).  If this is really the case, it is because both the native
installer and mozilla use xpcom, and xpcom has issues completely shutting down.

Patch coming up to cleanup the left over ns_tempX dirs.

Comment 1

[Sean Su]

Attachment: patch v1.0

This patch is moved from bug 197847 to here where it is more appropriate.  In
addition to fixing this bug, this patch also:
 * moves the check for other instances of mozilla running to before kicking off

the GRE installer
 * checks to see if Netscape is also running.  This is necessary because they
"could" share the same GRE.  And it's necessary to do this because there isn't
a way to check to see who's using GRE right now (that problem will be addressed

in bug 193173).  We just know that it's currently only mozilla and/or netscape
(until 3rd party developers start using GRE as well).

Comment 2

[Henrik Gemal]

if we can do the ns_tempX thing can't we also fix bug 183448 ?
"having a file called "ns_temp" in %TEMP makes the installer useless"

Comment 3

[Sean Su]

relavent comments pertaining to the attached patch from bug 197847.

 ------ Additional Comment #7 From Sean Su  2003-04-08 17:39 -------

 (From update of attachment 119894 [details] [diff] [review])
 samir is on vacation this entire week.	I can get sr= from someone else.


 ------ Additional Comment #8 From [e-mail] 2003-04-08 18:04 ---

 (From update of attachment 119894 [details] [diff] [review])
 r=dveditz


 ------ Additional Comment #9 From Sean Su 2003-04-08 18:40 -------

 (From update of attachment 119894 [details] [diff] [review])
 seeking rs= from sspitzer.


 ------ Additional Comment #10 From Seth Spitzer 2003-04-08 23:06 -----

 (From update of attachment 119894 [details] [diff] [review])
 rs=sspitzer, since you have r=dveditz

Comment 4

[Sean Su]

Comment on attachment 119943 [details] [diff] [review]
patch v1.0

already got r=dveditz, rs=sspitzer for this patch.

see bug 197847

Comment 5

[Sean Su]

Henrik, not necessarily.  Bug 183448 requires additional files to be touched
than what is in this patch (though it's not a difficult patch).  I'll see what I
can do since I'm messing this the ns_temp dir anyways.

Comment 6

[Sean Su]

patch checked in.  closing bug as fixed.

Comment 7

[Grace Bush]

Sean, I am still getting this message on a subsequent install - the ns_temp with
all files is there, this message gets displayed and I am knocked out of installer.

Comment 8

[Sean Su]

Attachment: patch v1.0.1

here's an additional patch that I accidentally removed after my tests.	I was
in the middle of fixing/testing too many bugs.

I've retested this and it works now.

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 120018 [details] [diff] [review]
patch v1.0.1

sr=dveditz

Comment 10

[Sean Su]

Thanks Dan!  patch checked in.

Comment 11

[Grace Bush]

verified with 4/10 builds, mozilla and commercial