Closed
Bug 2013621
Opened 3 months ago
Closed 3 months ago
--toolbar-bgcolor on body breaking Smart Window UI (content area is now grey instead of transparent revealing the purple gradient window background)
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
RESOLVED
FIXED
149 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr140 | --- | unaffected |
| firefox147 | --- | unaffected |
| firefox148 | --- | unaffected |
| firefox149 | --- | unaffected |
| firefox150 | --- | fixed |
People
(Reporter: mlucks, Assigned: Gijs)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression, Whiteboard: [genai][switcher])
Attachments
(1 file, 2 obsolete files)
Adding the token to body element has broken the UI for Smart Window, we need it to be transparent. We cannot affect this from the manifest file, it needs to happen within a different scope.
Flags: needinfo?(emilio)
|
||
Comment 1•3 months ago
|
||
Set release status flags based on info from the regressing bug 2005854
status-firefox147:
--- → unaffected
status-firefox148:
--- → unaffected
status-firefox149:
--- → affected
status-firefox-esr140:
--- → unaffected
|
Assignee | |
Updated•3 months ago
|
OS: Unspecified → All
Hardware: Unspecified → Desktop
Summary: --toolbar-bgcolor on body breaking Smart Window UI → --toolbar-bgcolor on body breaking Smart Window UI (content area is now grey instead of transparent revealing the purple gradient window background)
|
||
Comment 2•3 months ago
|
||
Hm? I'm confused, the only thing that's going on is that the background-image here is now being overridden, right?
Making those two !important would work but there might be a better fix. I'm traveling today so if it's very urgent you can just add !important to those two declarations.
Flags: needinfo?(emilio)
We cannot affect the body element we are targeting from the chrome, its technically already in the content. LMK what you think of my patch.
|
||
Updated•3 months ago
|
Assignee: nobody → mlucks
Status: NEW → ASSIGNED
|
||
Updated•3 months ago
|
|
|
||
Comment 5•3 months ago
|
||
|
|
||
Updated•3 months ago
|
Attachment #9541469 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•3 months ago
|
Blocks: dechromify-smartbar-css
|
|
Assignee | |
Comment 7•3 months ago
|
||
|
||
Updated•3 months ago
|
Priority: -- → P1
|
|
||
Updated•3 months ago
|
Attachment #9541445 -
Attachment is obsolete: true
Pushed by gijskruitbosch@gmail.com:
https://github.com/mozilla-firefox/firefox/commit/dd49b510f416
https://hg.mozilla.org/integration/autoland/rev/566bbfc3df57
restore AI window colours by removing browser-shared.css, r=mlucks,emilio,desktop-theme-reviewers,ai-frontend-reviewers
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
|
||
Updated•2 months ago
|
QA Whiteboard: [qa-triage-done-c150/b149]
You need to log in
before you can comment on or make changes to this bug.
Description
•