2014036 - Update treeherder to support alternate lando URLs

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement)

Description

[Olivier Mehani [:shtrom]]

In bug 1965997, we are moving to a new instance of lando, at https://lando.moz.tools for try Pushes.
It offers a compatible API to check jobs, but has a separate namespace for job id.

As part of bug 1979252, we are adding support for mach to use the new lando, while retaining support for the old lando.

At the end of a successful try push, mach instructs users to check https://treeherder.mozilla.org/jobs?repo=try&landoCommitID={job_id}".

We'll be keeping both instances for a short transition period, so we'll need to be able to tell Treeherder which Lando instance to use, for the landoCommitID to be valid. I'd suggest simply adding a landoInstance={old,new} parameter, defaulting to old if unspecified.

At some point the mach default will flip to using new lando by default (likely after updating ESRs) and we'll flip the default.

Comment 1

[Olivier Mehani [:shtrom]]

FWIW, I'm happy to do this myself, but I would welcome some discussion/suggestions as to the preferred way to proceed.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 2014036 - also return Lando instance for Try pushes. r=ahal,aryx,sparky

Needed by Treeherder to query the correct Lando instance to redirect to after
the Try push has been created and has been ingested by Treeherder.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 2014036 - Use Lando instance in urls created with mach try perf. r?#perftest

Comment 4

[Olivier Mehani [:shtrom]]

Attachment: [mozilla/treeherder] Bug 2014036 - support Lando instances to check landing status of Try pushes#9202

Comment 5

[Olivier Mehani [:shtrom]]

:Aryx: is there anything preventing the landing of your first mach path, and the treeherder PR? I'm thinking about excluding mach perf from automatically using the new instance for a bit longer, so we could move forwards with plain try for now.

Comment 6

[Olivier Mehani [:shtrom]]

FWIW: I now have a way to separate the dependency on Perf.Compare from that on TreeHerder (it's pretty simple: https://phabricator.services.mozilla.com/D285188), so we don't need to land all the fixes in one go, and we can land and support TreeHerder on its own as soon as it's ready.

Comment 7

[Olivier Mehani [:shtrom]]

Attachment: Bug 2014036 - add instance_id attribute to lando.ini sections r=ahal,aryx,sparky

This allows us to decouple the name of the lando instance from the
section in the configuration file. The instance_id is useful for tools
such as TreeHerder and PerfCompare to talk to the appropriate Lando
instance.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2cb7e08e4601
https://hg.mozilla.org/integration/autoland/rev/6379b0a0e97b
also return Lando instance for Try pushes. r=ahal,perftest-reviewers,sparky
https://github.com/mozilla-firefox/firefox/commit/1269c64056b3
https://hg.mozilla.org/integration/autoland/rev/71435819ab8d
add instance_id attribute to lando.ini sections r=ahal,sparky

Comment 9

[rperta]

https://hg.mozilla.org/mozilla-central/rev/6379b0a0e97b
https://hg.mozilla.org/mozilla-central/rev/71435819ab8d

Comment 10

[Olivier Mehani [:shtrom]]

Mach changes are in; TreeHerder changes still need to be merged.

Comment 11

[BMO Github Automation]

Authored by https://github.com/Archaeopteryx
https://github.com/mozilla/enterprise-firefox/commit/2cb7e08e46016c6e594ecbd9109da88f72b3b185
[enterprise-main] Bug 2014036 - also return Lando instance for Try pushes. r=ahal,perftest-reviewers,sparky

Authored by https://github.com/shtrom
https://github.com/mozilla/enterprise-firefox/commit/1269c64056b3b3b9720863310e8306ae0fee342d
[enterprise-main] Bug 2014036 - add instance_id attribute to lando.ini sections r=ahal,sparky

Comment 12

[Marco Castelluccio [:marco]]

Is there more to do here?

Comment 13

[Olivier Mehani [:shtrom]]

There is still one patch which hasn't landed, but it's waiting for support on the Perf.Compare side (bug 2014041)

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c778e4c62f1c
https://hg.mozilla.org/integration/autoland/rev/4151518b7d38
Use Lando instance in urls created with mach try perf. r=perftest-reviewers,aryx,shtrom,aglavic

Comment 15

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/4151518b7d38