2014041 - Update perf.compare to support alternate lando URLs

Status: RESOLVED FIXED

(Testing :: PerfCompare, enhancement, P3)

Description

[Olivier Mehani [:shtrom]]

In bug 1965997, we are moving to a new instance of lando, at https://lando.moz.tools for try Pushes.
It offers a compatible API to check jobs, but has a separate namespace for job id.

As part of bug 1979252, we are adding support for mach to use the new lando, while retaining support for the old lando.

When using a mach try perf mach instructs users to check https://perf.compare/compare-lando-results?baseLando=177080&newLando=177081&baseRepo=try&newRepo=try&framework=15

We'll be keeping both instances for a short transition period, so we'll need to be able to tell Perf.Compare which Lando instance to use, for the baseLando and newLando jobIds to be valid. I'd suggest simply adding a landoInstance={old,new} parameter, defaulting to old if unspecified.

At some point the mach default will flip to using new lando by default (likely after updating ESRs) and we'll flip the default.

We have a similar bug for TreeHerder: bug 2014036

Comment 1

[Olivier Mehani [:shtrom]]

FWIW, I'm happy to do this myself, but I would welcome some discussion/suggestions as to the preferred way to proceed.

Comment 2

[Olivier Mehani [:shtrom]]

From sparky:

given that you'll be supporting both for a bit, you could start with either adding the flag "landoInstance" to mach try perf when we build the url https://searchfox.org/firefox-main/source/tools/tryselect/selectors/perf.py#1666 or start with accepting that option in perfcompare. For perfcompare, you'd need to add a new function to handle the new API call then use it in the landoToCommitLoader https://github.com/mozilla/perfcompare/blob/499093107fc3a2e337a3319d434186baec356dae/src/components/CompareResults/landoToCommitLoader.ts#L33-L38.

Comment 3

[Olivier Mehani [:shtrom]]

Note from :sparky:

we'd need to adjust this code to accept a new URL param for the lando instance to use: https://github.com/mozilla/perfcompare/blob/ec289b8132df0d67b017869aa2ed76a601b0654f/src/logic/lando.ts#L5-L19

Comment 4

[Olivier Mehani [:shtrom]]

Attachment: [mozilla/perfcompare] Bug 2014041: add support for landoInstance QueryString parameter#1038

Comment 5

[Olivier Mehani [:shtrom]]

Landed https://github.com/mozilla/perfcompare/pull/1038#event-25833366128