Closed Bug 2015252 Opened 3 months ago Closed 2 months ago

Add 'reverse tabs' menu option to the tab context menu for tabs in a Splitview

Categories

(Firefox :: Tabbed Browser: Split View, enhancement, P2)

enhancement

Tracking

()

VERIFIED FIXED
150 Branch
Tracking Status
relnote-firefox --- 150+
firefox149 + wontfix
firefox150 --- verified

People

(Reporter: flod, Assigned: kcochrane)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-splitview])

Attachments

(3 files, 2 obsolete files)

It would be very useful to have a quick way to flip the two tabs displayed in Split view (A-B to B-A).

Priority: -- → P2
Whiteboard: [fidefe-splitview]

(In reply to Francesco Lodolo [:flod] from comment #0)

It would be very useful to have a quick way to flip the two tabs displayed in Split view (A-B to B-A).

Are you finding it not convenient to reverse the tabs via the footer in the inactive panel or urlbar indicator menu options?

Flags: needinfo?(francesco.lodolo)

They're perfectly usable, but I don't think they're discoverable.

I've been using this feature from the beginning, and yet I discovered the menu via Slack, and the address bar icon literally from your message.

Flags: needinfo?(francesco.lodolo)
Summary: Allow switching the tabs displayed in Split view → Add 'reverse tabs' menu option to the tab context menu for tabs in a Splitview
Assignee: nobody → kcochrane

Laura, can we please ask you to weigh in whether you think the string should be:
Reverse tabs
OR
Reverse Tabs in Split View (more verbose, but possibly more helpful?)

This option will only appear in context menu of a tab added to the split view. I also attached the screenshot to show how Reverse tabs string would look like.

Attached image reverse tabs β€”
Blocks: 1980370
Status: NEW → ASSIGNED

Laura, quick flag - we went for Reverse tabs (since it's past string freeze, and we already have that string in Fluent).
We can change it in release 150 if we feel strongly about the longer string being better.

Pushed by sthompson@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/7c6c195b040f https://hg.mozilla.org/integration/autoland/rev/36b6b9f83907 Add 'Reverse Tabs' option to the tab context menu for split view tabs r=tabbrowser-reviewers,fluent-reviewers,dwalker,sthompson,bolsson
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch

firefox-beta Uplift Approval Request

  • User impact if declined: Users will not have a way to reverse split view tabs in the tab context menu
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: yes
  • Steps to reproduce for manual QE testing: Create a split view. Right click one of the split view tabs and confirm you see a new menu option for Reverse Tabs. Clicking the option should swap the order of the tabs in the split view. This new option should only show for split view tabs and will not show if tabs are multiselected.
  • Risk associated with taking this patch: low
  • Explanation of risk level: Adding a new split view specific context menu option that is covered by automated tests.
  • String changes made/needed: N/A
  • Is Android affected?: no
Attachment #9549384 - Flags: approval-mozilla-beta?
Flags: qe-verify+

(In reply to Phabricator Automation from comment #9)

  • String changes made/needed: N/A

The patch is adding a string to browser/locales/en-US/browser/tabbrowser.ftl
I believe you need l10n-drivers approval, flod, is that OK to uplift?

Flags: needinfo?(francesco.lodolo)

I'm redirecting to Bryan, but also confused by this comment from Ania

Laura, quick flag - we went for Reverse tabs (since it's past string freeze, and we already have that string in Fluent).

I understood that 149 was going to use an existing string?
https://searchfox.org/firefox-main/source/browser/locales/en-US/browser/tabbrowser.ftl#460-461

Flags: needinfo?(francesco.lodolo) → needinfo?(bolsson)

The string tab-context-reverse-split-view just landed in tree at the end of the day yesterday which leaves 2 weeks for localizations. There's a greater risk that this string would appear in English for some locales. Instead of uplifting this string, could we temporarily reference the existing string split-view-menuitem-reverse-tabs for 149 instead?

Flags: needinfo?(bolsson) → needinfo?(kcochrane)
QA Whiteboard: [uplift][qa-ver-needed-c150/b149]

The reason I didn't use the existing string was because there is no access key defined for it. I would add an access key to the existing string, but that would add an access key to that option in existing menus where it didn't exist previously. Ex: The split view popup menu from the Urlbar and split view footer.

I'm reaching out to :asafko on which route we should go here:
Sounds like we can do one of the following:

  • Uplift with the existing string but it will have no access key in the tab context menu
  • Uplift with the existing string and add an access key which will add an access key to other existing menus unexpectedly
  • Not uplift this and let it ride the train for 150
Flags: needinfo?(kcochrane) → needinfo?(bolsson)

Update: Ania would like us to go with the existing string with no access key for the uplift. Working on a new patch for that now.

Flags: needinfo?(bolsson)
Blocks: 2021063
Attachment #9550016 - Flags: approval-mozilla-beta?
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/230e8b941caf https://hg.mozilla.org/integration/autoland/rev/ba88f2c34305 Use existing 'Reverse Tabs' string for new tab context menu option r=fluent-reviewers,bolsson

(In reply to Pulsebot from comment #18)

Pushed by kcochrane@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/230e8b941caf
https://hg.mozilla.org/integration/autoland/rev/ba88f2c34305
Use existing 'Reverse Tabs' string for new tab context menu option
r=fluent-reviewers,bolsson

Why did we land this on main? Isn't this just a temporary fix for beta and 149?

Flags: needinfo?(kcochrane)

Hello! I have verified with Firefox 150.0a1 (2026-03-05) on Windows 11, macOS 26, and Ubuntu 24 that the Reverse tabs context menu option is displayed and works as expected for both views in horizontal and vertical tabs. The Revese tabs context menu option is not displayed when other tab and Split View are selected.
However, I have two questions:

  1. I see that pressing the R keyboard key on Windows/ Linux when the context menu is open no longer reloads the tab as before. It cycles between the Reverse Tabs option and the Reload Tab.
  2. The Reverse tabs context menu option is not displayed when both views are selected.

Are the above expected? Thank you!

Has STR: --- → yes

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

(In reply to Francesco Lodolo [:flod] from comment #19)

(In reply to Pulsebot from comment #18)

Pushed by kcochrane@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/230e8b941caf
https://hg.mozilla.org/integration/autoland/rev/ba88f2c34305
Use existing 'Reverse Tabs' string for new tab context menu option
r=fluent-reviewers,bolsson

Why did we land this on main? Isn't this just a temporary fix for beta and 149?

I was asked to write a follow-up bug to switch back to the other string: https://bugzilla.mozilla.org/show_bug.cgi?id=2021063

If it's easier, we can backout the change to main and only uplift the change for beta, but I wasn't sure how to uplift something I hadn't also done for main.

Flags: needinfo?(kcochrane)

(In reply to Alexandru Trif, Desktop Test Engineering [:atrif] from comment #20)

Hello! I have verified with Firefox 150.0a1 (2026-03-05) on Windows 11, macOS 26, and Ubuntu 24 that the Reverse tabs context menu option is displayed and works as expected for both views in horizontal and vertical tabs. The Revese tabs context menu option is not displayed when other tab and Split View are selected.
However, I have two questions:

  1. I see that pressing the R keyboard key on Windows/ Linux when the context menu is open no longer reloads the tab as before. It cycles between the Reverse Tabs option and the Reload Tab.

We are now using the existing string for this that does not include an access key: https://searchfox.org/firefox-main/source/browser/locales/en-US/browser/tabbrowser.ftl#464
In bug 2021063, we will switch back to using the string with the access key: https://searchfox.org/firefox-main/source/browser/locales/en-US/browser/tabbrowser.ftl#453

  1. The Reverse tabs context menu option is not displayed when both views are selected.

We decided that the 'Reverse Tabs' option will not show when multiselection is being used regardless of if both tabs are in a split view. We wanted to avoid a scenario where a user selects multiple tabs across multiple split views and tries to reverse all the tabs. It will only show when you right click one split view tab.

Flags: needinfo?(francesco.lodolo)
Flags: needinfo?(atrif)

Not sure what the question for the NI is? I don't have a problem with landing and then fixing, but I'd be surprised if you can't land a patch directly to beta via RelMan (it's definitely possible for ESR).

We are now using the existing string for this that does not include an access key: https://searchfox.org/firefox-main/source/browser/locales/en-US/browser/tabbrowser.ftl#464
In bug 2021063, we will switch back to using the string with the access key: https://searchfox.org/firefox-main/source/browser/locales/en-US/browser/tabbrowser.ftl#453

Pretty sure the issue is with the new string, not with the one in Beta (that doesn't have an accesskey). So, you might have to pick another accesskey in the followup.

Flags: needinfo?(francesco.lodolo)
Flags: needinfo?(atrif)

(In reply to Francesco Lodolo [:flod] from comment #25)

Not sure what the question for the NI is? I don't have a problem with landing and then fixing, but I'd be surprised if you can't land a patch directly to beta via RelMan (it's definitely possible for ESR).

Yes, no problem landing a patch directly to beta to address a release-specific issue.

Attachment #9549384 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9550016 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Kelly, your patches do not apply cleanly to the beta branch, could you rebase them please? Thanks

Flags: needinfo?(kcochrane)

Rebased

Flags: needinfo?(kcochrane)

Confirming that the Reverse tabs context menu option is present in Firefox 149.0b5 (20260305221805) for a Split View when no multiselection is used. Also, the R key is not assigned for the Reverse Tabs. Unfortunately, I discovered bug 2021527 when testing this.

Status: RESOLVED → VERIFIED
QA Whiteboard: [uplift][qa-ver-needed-c150/b149] → [uplift][qa-ver-done-c150/b149]
Flags: qe-verify+

Given the discovery of bug 2021527, we'd like to back out this stack of patches from 149 beta and just have it ride the trains to 150.

Flags: needinfo?(pascalc)

Reverted. Tracking for a potential uplift in our planned dot release.

Flags: needinfo?(pascalc)
Attachment #9549384 - Attachment is obsolete: true
Attachment #9550016 - Attachment is obsolete: true

:kcochrane did you want to include this in the 150 release notes? Please nominate if so.

Flags: needinfo?(kcochrane)
Flags: needinfo?(kcochrane) → needinfo?(asafko)

I added a note to release notes here.
It's a joint note with another bug, sharing the text here just in case:
_Split View just got better: right-click any link and choose Open Link in Split View to open it alongside your current tab. You can also quickly reverse tab positions using the new Reverse Tabs option in the tab context menu.
_

Flags: needinfo?(asafko)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: