2015447 - Assistant chat area is displayed without bottom and side margins

Status: RESOLVED FIXED

(Core :: Machine Learning: Frontend, defect, P1)

Description

[Ciprian Georgiu, Desktop QA]

Attachment: screenshot with the correct alignment

Found in

• latest Nightly 149.0a1

Affected versions

• latest Nightly 149.0a1

Tested platforms

• Affected platforms: Ubuntu 24, macOS, Win 11

Preconditions

• browser.smartwindow.enabled = true

Steps to reproduce

1. Reach any website in a Smart Window.
2. Open the Assistant Sidebar.
3. Observe the Assistant chat position.

Expected result

• The Assistant chat area has a slight space left at the bottom of the page as well as on the edges, as shown in the Figma specs.

Actual result

• The Assistant chat area is displayed with no margins at the bottom and sides of the page.

Regression range

• Not a regression.

Additional notes

• Please see the attached screenshot.

Comment 1

[Giulia Cardieri (:gcardieri)]

Attachment: Bug 2015447 - account for window splitter on smartbar width for smartwindow sidebar

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6a34166d3c6c
https://hg.mozilla.org/integration/autoland/rev/11c960cb3419
account for window splitter on smartbar width for smartwindow sidebar r=desktop-theme-reviewers,ai-frontend-reviewers,Gijs,dao

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/11c960cb3419

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/11c960cb3419

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 9

[BMO Github Automation]

Authored by https://github.com/gcardieri
https://github.com/mozilla/enterprise-firefox/commit/6a34166d3c6c417f9c31a34039eef395ef341d9c
[enterprise-main] Bug 2015447 - account for window splitter on smartbar width for smartwindow sidebar r=desktop-theme-reviewers,ai-frontend-reviewers,Gijs,dao

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gcardieri, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox150 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Justin Levinsohn]

It is not necessary to uplift this one.