2015461 - Allow reordering of hidden search engines

Status: VERIFIED FIXED

(Firefox :: Search, task, P1)

Description

[Mark Banner (:standard8)]

With the new settings design, we'll be keeping hidden application provided engines available in the list of engines. The engines will still be shown as reorderable, and we think it'd be confusing for the user not to reorder them. Hence we should change the search service so that it stores the order for all engines (not just visible), and allow hidden engines to be moved.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 2015461 - Allow reordering of hidden search engines for the new settings UI. r?scunnane!

This enables reordering for hidden search engines for the new settings table. We leave the existing
code in place for the pre-settings table, until we have turned that on completely, this is to avoid
breaking functionality in the meantime.

This also adds a more explicit test for moveEngine - some tests already test it a little, but not
extensively.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fd04c5066699
https://hg.mozilla.org/integration/autoland/rev/e297fbc620e2
Allow reordering of hidden search engines for the new settings UI. r=scunnane,tgiles

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e297fbc620e2

Comment 4

[Dana Lucaci, Desktop QA]

Verified as fixed with Firefox 150.0a1 (20260224095058) and Firefox 149.0b1 (20260225100912) on macOS 15 ARM, Ubuntu 22.04 and Windows 10.