1968110 - Convert settings related to Search page to config-based settings

Status: RESOLVED FIXED

(Firefox :: Settings UI, task)

Description

[Mark Striemer [:mstriemer]]

The Search page will need to be converted to the config-based settings structure. If settings share a similar pattern to the current design then it may make sense to convert them to the SRD 2025's new design. If they differ significantly, it may be necessary to create a custom component for the old version, and a new version; ideally this can still share most of the business logic to avoid regressions later.

This page will have the following sections which may be good candidates for individual bugs to work on:

• Default search engine
• Search Suggestions
• Address Bar - Firefox Suggest
• Search Shortcuts

Comment 1

[Hanna Jones [:hjones]]

Once all the blocking conversions are complete this bug will cover the work involved in reorganizing the relevant sections to create the finalized Search page as specified in Figma here: https://www.figma.com/design/2b02v18AppIpsTceWac2T3/Settings-Desktop?node-id=6396-14169&m=dev

As part of this work we should also make sure all the strings and illustrations match the design.

Comment 3

[Hanna Jones [:hjones]]

To complete the work on this ticket we need to start generating the new Search settings pane via config. There's an example of us doing this work for the Account and Sync pane here. Basically the steps are as follows:

• create a new browser/components/preferences/config/search.mjs file for all of the new/config-based search code
• migrate any code needed for config-based search settings to that file from search.js and main.js (e.g. config like this and all of these addSetting calls), then import that file back into search.js (this will allow the old code to keep working as expected)
  • this will allow us to easily remove the old code down the line by just deleting the search.js file
• add a new entry for the search pane to CONFIG_PANES here
  • more info on the various config options can be found here
  • it looks like the order of the settings may have changed in the mockups - implementing this should be as simple as changing the order of items in the groupIds array
• do a final string and illustration check to make sure all of the copy is up to date

If you run into any unexpected issues just reach out in #the settings-redesign channel

Comment 4

[Stephanie Cunnane [:scunnane]]

Attachment: Bug 1968110 - Generate new search settings pane via config. r?hjones!,Standard8

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cc0c7ef0882a
https://hg.mozilla.org/integration/autoland/rev/38ad80672070
Generate new search settings pane via config. r=Standard8,hjones,fluent-reviewers,flod

Comment 6

[rperta]

https://hg.mozilla.org/mozilla-central/rev/38ad80672070