2016944 - TB extension-related tests fail with "error not implemented", splitViewId

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect, P1)

Description

[Kai Engert [:KaiE:]]

Since today's m-c push many TB tests fail.

For example: https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=QeDjKEPXSbe1Ek_cggrE8Q.0

INFO - Entering test testExtensionTab
INFO - Extension loaded
INFO - [dialog] opened: windowtype="" uri="chrome://extensions/content/dummy.xhtml" title=""
INFO - Console message: [JavaScript Error: "Not implemented" {file: "chrome://extensions/content/parent/ext-tabs-base.js" line: 542}]
INFO - get splitViewId@chrome://extensions/content/parent/ext-tabs-base.js:542:11
INFO - convert@chrome://extensions/content/parent/ext-tabs-base.js:693:7
INFO - convert@chrome://messenger/content/parent/ext-mail.js:882:26
INFO - convert@chrome://extensions/content/parent/ext-tabs-base.js:2091:39
INFO - create@chrome://messenger/content/parent/ext-tabs.js:568:29
INFO - async*recvAPICall/result</</<@resource://gre/modules/ExtensionParent.sys.mjs:1223:16

Comment 1

[Kai Engert [:KaiE:]]

Probably caused by bug 1993037 which introduced a new API that TB doesn't implement.

Comment 2

[Rob Wu [:robwu]]

See "mobile/" on the patch for inspiration on how to fix it. Firefox for Android does not have split view feature so it has the minimum for API compatibility.

To find relevant files in TB to touch, here is a recent example of a patch that added the bare minimum for groupId in TB: bug 1960156

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Bug 2016944 - Implement extension API splitViewId. r=#thunderbird-reviewers

Comment 4

[Kai Engert [:KaiE:]]

Thank you Rob !

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e69092ce7418
Implement extension API splitViewId. r=coreycb