Closed Bug 2017223 Opened 3 months ago Closed 3 months ago

Shutdown blocker race in SERPCategorization DomainToCategoriesStore

Categories

(Firefox :: Search, defect)

defect

Tracking

()

RESOLVED FIXED
149 Branch
Tracking Status
firefox149 --- fixed

People

(Reporter: jstutte, Assigned: jstutte)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

DomainToCategoriesStore.#closeConnection() removes its Sqlite.shutdown blocker before closing the connection. If shutdown started while the close was in-flight, the connection was unprotected and could block the main thread in Connection::shutdownAsyncThread rather than on the blocker in its phase.

Blocks: 1679425

DomainToCategoriesStore.#closeConnection() removed its Sqlite.shutdown
blocker before closing the connection. If shutdown started while the
close was in-flight, the connection was unprotected and could block
the main thread in Connection::shutdownAsyncThread.

Move the blocker removal after the connection close.

Assignee: nobody → jstutte
Attachment #9545634 - Attachment description: WIP: Bug 2017223 - Fix shutdown blocker race in SERPCategorization DomainToCategoriesStore. r?#search-reviewers → Bug 2017223 - Fix shutdown blocker race in SERPCategorization DomainToCategoriesStore. r?#search-reviewers
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
QA Whiteboard: [search] [qa-triage-done-c149/b148]
QA Whiteboard: [search] [qa-triage-done-c149/b148] → [qa-triage-done-c150/b149]
QA Whiteboard: [qa-triage-done-c150/b149] → [qa-triage-done-c150/b149][search]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: