2017227 - Reduce the impact of Database::Shutdown currently doing a "PRAGMA optimize(0x02)"

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement)

Description

[Jens Stutte [:jstutte]]

PRAGMA optimize(0x02) was introduced by bug 1354032, before SQLite introduced the analysis limit. We can reduce the impact of analysis on large databases by using the mask 0x12 instead.

Comment 1

[Jens Stutte [:jstutte]]

Attachment: Bug 2017227 - Use time-bounded PRAGMA optimize for Places databases r?#places-reviewers

PRAGMA optimize(0x02) replaces the default mask (0x0fffe), which
disables the 0x10 row-limiting flag. This means ANALYZE runs without
a row limit and can take a long time on large places.sqlite databases,
contributing to shutdown hangs.

Switch to 0x12 (0x02 | 0x10) at shutdown to cap ANALYZE runtime.
Also add PRAGMA optimize to PlacesDBUtils idle maintenance with
0x10012 to cover long-running sessions where shutdown is infrequent.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/df9ad3fc1d2c
https://hg.mozilla.org/integration/autoland/rev/13417e8747e8
Use time-bounded PRAGMA optimize for Places databases r=places-reviewers,mak

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/13417e8747e8