2017230 - Add async shutdown blocker to CookiePersistentStorage

Status: RESOLVED FIXED

(Core :: Networking: Cookies, enhancement, P2)

Description

[Jens Stutte [:jstutte]]

If we hang when the DB is closed we currently lump this into bug 1679425. CookiePersistentStorage should have its own shutdown handling.

Comment 1

[Jens Stutte [:jstutte]]

Attachment: Bug 2017230 - Add async shutdown blocker to CookiePersistentStorage r?#cookie-reviewers

CookiePersistentStorage had no async shutdown blocker. During shutdown,
Close() synchronously joined the Cookie thread and then fired AsyncClose,
but nothing held the shutdown barrier while sqlite3_close completed on
the async thread. This caused the main thread to block in
Connection::shutdownAsyncThread waiting for slow WAL truncation I/O.

Add an nsIAsyncShutdownBlocker on profile-before-change that initiates
the close in BlockShutdown and is removed when HandleDBClosed fires
after AsyncClose completes. Remove the now-redundant profile-before-change
and profile-do-change observers from CookieService, as runtime profile
switching no longer exists. Add testCloseCookieDB/testOpenCookieDB IDL
methods to replace the tests' direct observe() calls for simulating
profile changes.

Note that this will not fix the shutdown hang as such, it will just make it
attributable to the CookieService more easily.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ed27d9c3bfd5
https://hg.mozilla.org/integration/autoland/rev/4b4b92290b18
Add async shutdown blocker to CookiePersistentStorage r=cookie-reviewers,valentin

Comment 3

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/4b4b92290b18

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/4b4b92290b18