2017257 - Unable to reach the Used Memories from the Memories used panel with Keyboard navigation

Status: VERIFIED FIXED

(Core :: Machine Learning: Frontend, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: AppliedMemories.mp4

Found in

• Nightly 149.0a1 (2026-02-17)

Affected versions

• Nightly 149.0a1 (2026-02-17)

Affected platforms

• all

Steps to reproduce

1. Open a New smart window.
2. Ask the assistant something a memory would be used for.
3. Use the Tab key in order to reach the Memories used button and open the panel.
4. Use the Tab key in order to reach and Delete the Used memories.

Expected result

• The Memories displayed in the Memories used panel should be reachable with Keyboard navigation and the user should be able to delete them from the X Close/Delete button.

Actual result

• The Memories from the Memories used panel cannot be reached with Keyboard Navigation.

Regression range
N/A

Comment 1

[James Teh [:Jamie]]

S2 because this is inoperable using the keyboard.

Comment 2

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:Mardak, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Chloe Zhou [:chloezhou]]

Attachment: Bug 2017257 - Add keyboard support and hcm mode styles to applied memories popover r=#ai-frontend-reviewers,echa,ayeddi

Add keyboard support to the applied-memories-button popover so that it is fully operable without a mouse. The focus trap cycles through the trigger button and all focusable popover elements, allowing the user to Tab to the "Memories used" button to close the popover.

Replace aria-hidden with the inert attribute on the closed popover so that it is hidden from both assistive technology and keyboard/pointer interaction. Switch remove-button visibility from display: none/inline-flex to opacity: 0/1 so the buttons remain focusable and the :focus-within selector can reveal them when tabbing through the memory list.

Keep remove buttons always visible in forced-colors mode for high contrast accessibility.

Add browser test covering Tab, Shift+Tab, Escape, and inert state.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fddced9457ce
https://hg.mozilla.org/integration/autoland/rev/492f1b4e63be
Add keyboard support and hcm mode styles to applied memories popover r=echa,ai-frontend-reviewers,accessibility-frontend-reviewers,fluent-reviewers,bolsson,morgan

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/492f1b4e63be

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/492f1b4e63be

Comment 8

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:chloezhou, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox150 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly build, however, @Morgan is it ok that we can only use the Arrow keys once we open the Applied memories panel ? if we hit tab while we are on the X Close button of a memory it will close the panel instead of moving to the other buttons, also it seems that by default the focus goes straight to the X delete button, users might accidentally deleted memories because of that.

Comment 10

[Morgan Reschenberg [:morgan]]

(In reply to Rares Doghi, Desktop QA from comment #9)

This issue is verified as fixed in our latest Nightly build, however, @Morgan is it ok that we can only use the Arrow keys once we open the Applied memories panel ? if we hit tab while we are on the X Close button of a memory it will close the panel instead of moving to the other buttons, also it seems that by default the focus goes straight to the X delete button, users might accidentally deleted memories because of that.

yeah, this is okay for now -- we're working on addressing this issue and better screen reader support in bug 2028677 which should land soon. I still think the work in nightly is better than what we had.

thanks for testing it !

Comment 11

[Ed Lee :Mardak]

chloe, this bug seems to want accessibility s2 uplift to release 150 dot release, so could you make the request or mark this wontfix as per comment 8?

Comment 12

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: This is an accessibility S2 bug. Keyboard-only and assistive technology users cannot fully operate the "Memories used" popover in AI chat: there is no arrow key navigation between menu items, no Escape/Tab to close, and focus is not managed on open. High Contrast Mode users also see broken visuals: incorrect backgrounds, invisible delete buttons, and missing item borders. These are baseline WCAG 2.1 requirements. Declining leaves keyboard and HCM users with an inaccessible UI for the full release cycle.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Low. Changes are entirely scoped to the applied-memories-button custom element in the AI chat UI. The keyboard handling adds a new keydown listener without modifying existing click or popover-open logic. CSS additions follow the existing --custom-property override pattern already in use in this component.
• String changes made/needed?: Yes. One new FTL string is added in browser/locales-preview/aiWindowContent.ftl:

aiwindow-applied-memories-popover =
.aria-label = Applied memories

• Is Android affected?: no

Comment 13

[Chloe Zhou [:chloezhou]]

Attachment: Bug 2017257 - Add keyboard support and hcm mode styles to applied memories popover r=echa,ai-frontend-reviewers,accessibility-frontend-reviewers,fluent-reviewers,bolsson,morgan

Add keyboard support to the applied-memories-button popover following the WAI-ARIA menu button pattern. Arrow keys navigate between all menu items (delete buttons, manage, retry) with wrapping; Home/End jump to the first/last item. Tab closes the menu and returns focus to the trigger. Escape closes the menu and returns focus to the trigger. The first item receives initial focus on open via roving tabindex.

Replace aria-hidden with the inert attribute on the closed popover so that it is hidden from both assistive technology and keyboard/pointer interaction.

Add forced-colors styles for the memories popover using the :host variable override pattern: define custom properties with default values on :host and override them inside a nested @media (forced-colors) block with semantically appropriate design tokens. This covers default, hover, active, and focus states for memory items, remove buttons, and action row buttons.

Add browser test covering ArrowDown, ArrowUp, Home, End, Tab, Escape, and inert state.

Original Revision: https://phabricator.services.mozilla.com/D290576

Comment 14

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/f61aa73f58ca
https://hg.mozilla.org/releases/mozilla-release/rev/7817a450afe8

Comment 15

[Rares Doghi, Desktop QA]

Verified as fixed in our latest 150.0.1