2017270 - Follow-up to bug 2012358: Reconsider path display in filter action target. Adjust for RTL locales

Status: RESOLVED FIXED

(Thunderbird :: Filters, defect)

Description

[Francesco]

I'm filing this as a follow-up to bug 2012358 as the discussion has fizzled out there.

IMHO, https://hg-edge.mozilla.org/comm-central/rev/7ef394bc86a2#l3.12 should be reverted as it makes for an inconsistent and "not to pretty" display, especially given that the tooltip is the same as the display itself. See attachment 9545353 [details] and attachment 9545363 [details].

It should be noted that in most other parts of the system, folders are displayed as "folder on account" and not a path. This is true for "Run selected filters on" or also folders shown in the account manager. In fact, everywhere where displayformat="verbose" is used:
https://searchfox.org/comm-central/search?q=%22verbose%22&path=&case=false&regexp=false

As far as I can see, no UI review was done for the UI change. Alessandro, what's your take on the UI change? It looks like the UI was changed to cater for the need on one particular user without keeping the overall system appearance in mind.

Furthermore the "folder -- account" string doesn't work for RTL locales because there "folder on account" becomes "tnuocca no redlof".

Comment 1

[Hartmut Welpmann [:welpy-cw]]

(In reply to Francesco from comment #0)

Furthermore the "folder -- account" string doesn't work for RTL locales because there "folder on account" becomes "tnuocca no redlof".

This can (and should IMO) generally be fixed, see bug 2012358 comment 5.

Comment 2

[Francesco]

(In reply to Hartmut Welpmann [:welpy-cw] from comment #1)

This can (and should IMO) generally be fixed, see bug 2012358 comment 5.

Here's the bug to do it.

Reverting https://hg-edge.mozilla.org/comm-central/rev/7ef394bc86a2#l3.12 is just an additional one-liner (if the decision is taken to revert it).

Comment 3

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 2017270 - Localize folder picker tooltip and restore verbose display format. r=#thunderbird-front-end-reviewers,#thunderbird-reviewers

• Use the localized display format "Path/To/Folder on Account" for the folder
  picker tooltip, replacing the hardcoded formatting introduced in bug 2012358.

• Fix a bug where the tooltip displayed stale data by ensuring tooltiptext is
  reset to an empty string when no folder path is available.

• Restore the "verbose" display format for folders selected in the folder
  picker, reverting the change in bug 2012358 that showed the full path.

• Update the "path" display format logic to also utilize the localized verbose
  format strings for better consistency (Currently unused).

Comment 4

[Mark Barnes [:WoofGrrrr]]

Those are good points, but I think its preferable when a tooltip has the same information as the underlying UI element when that UI element does not provide enough space to display the full text, while the tooltip can display more.

Here is the example from the first screenshot:

• AA/BB/CC on Local Folders

But consider the second screenshot. If the user hasn't made the Filter Editor wide enough just so they can view the full folder path like that, the path in the Menu Button will get chopped off, while the tooltip can display the whole path. I think this is the example from that screenshot.:
-AAAAAAAAAA/BBBBBBBBBB/CCCCCCCCCC/DDDDDDDDDD/EEEEEEEEEE/FFFFFFFFFF/GGGGGGGGGG/HHHHHHHHHH - Local Folders

Sorry, I don't have the daily release, so I can't give you a screenshot of that.

But still, having at least the tooltip would solve the problem for me. The original request was this:

1. The full path of the Folder should be displayed as a tooltip.
2. The elements of the currently-selected folder's path should be highlighted.

Comment 5

[Hartmut Welpmann [:welpy-cw]]

Attachment: Screenshot_2026-02-18_00-03-54.png

(In reply to Mark Barnes [:WoofGrrrr] from comment #4)

But still, having at least the tooltip would solve the problem for me. The original request was this:

1. The full path of the Folder should be displayed as a tooltip.
2. The elements of the currently-selected folder's path should be highlighted.

With the proposed patch in this bug it would look like this.

Comment 6

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 2017270 - Ensure correct icon and tooltip after changing folder in new folder dialog. r=#thunderbird-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9967e60078b6
Localize folder picker tooltip and restore verbose display format. r=darktrojan

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ed4caf306cac
Ensure correct icon and tooltip after changing folder in new folder dialog. r=darktrojan