2017287 - Add a placeholder icon in the new additional search engines table when a search engine does not have an icon

Status: VERIFIED FIXED

(Firefox :: Settings UI, task, P1)

Description

[Mark Banner (:standard8)]

Generally search engines should have icons, but sometimes there's a chance that they won't, when that's the case, we should use our normal placeholder fallback.

STR

1. Enable the settings redesign (if not already).
2. Add a search engine with the URL as https://example.com/?q=%s
3. View the engine in the table

Actual Results

There is no icon, and the text is misaligned with respect to the other engines.

Expected Results

There should be a placeholder icon.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 2017287 - Add a placeholder icon when necessary for search engines in the new additional search engines table. r?scunnane!

This also drops the cache of icons - SearchEngine and ConfigSearchEngine already cache these, and for the different areas
we need different sizes, so it doesn't seem worth keeping intermediatary caches of the icon urls.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/70da426d931b
https://hg.mozilla.org/integration/autoland/rev/c9fe451da359
Add a placeholder icon when necessary for search engines in the new additional search engines table. r=scunnane,mstriemer

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c9fe451da359

Comment 4

[Dana Lucaci, Desktop QA]

Reproduced with Firefox 149.0a1 (2026-02-17) on macOS 15 ARM.
Verified as fixed with Firefox 150.0a1 (20260224095058) and Firefox 149.0b1 (20260225100912) on macOS 15 ARM, Ubuntu 22.04 and Windows 10.