2017461 - Use CSSNumberish for Animation.currentTime

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement)

Description

[Boris Chiou [:boris]]

This is similar with Bug 2017448. However, we would like to update Animation.currentTime here:

[Exposed=Window]
partial interface Animation {
    ...
    attribute CSSNumberish?       currentTime;
    ...
};

Here is the webidl code.

Also, when we are setting the currentTime, we have to apply the algorithm of validating a CSSNumberish time.

Besides, we have to update AnimationPlaybackEvent.currentTime and AnimationPlaybackEventInit.currentTime (spec, webidl).

Comment 1

[Jonathan Watt [:jwatt]]

I'm looking at bug 2017448 first.

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: Bug 2017461. Use CSSNumberish for Animation.currentTime. r=boris

The behavior is gated on NIGHTLY_BUILD + layout.css.typed-om.enabled so
release builds continue to return a plain double.

For the setter:

• Progress timeline: CSSUnitValue must be convertible to percent;
  plain double is rejected.
• Monotonic timeline: CSSUnitValue must be convertible to number,
  ms, or s.

The ConvertTimeToCSSNumberish and ConvertCSSNumberishToTime helpers on
Animation will allow the logic to be reused in bug 2017448 for the
related Animation.startTime.

Also threads the CSSNumberish currentTime through AnimationPlaybackEvent
(and its init dictionary) by snapshotting an isPercent flag at
queue time and reconstructing the CSSUnitValue at dispatch time in
AnimationEventDispatcher.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e15cae629eda
https://hg.mozilla.org/integration/autoland/rev/a1139aa0d7ba
Use CSSNumberish for Animation.currentTime. r=boris,webidl,layout-scroll-driven-animation-reviewers,firefox-style-system-reviewers,smaug,dshin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/83e3e29d5da4
https://hg.mozilla.org/integration/autoland/rev/e50916bf7d87
Remove scroll-animations/view-timelines/block-view-timeline-current-time-vertical-rl.tentative.html.ini

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/a1139aa0d7ba
https://hg.mozilla.org/mozilla-central/rev/e50916bf7d87