Enable libz-rs-sys by default on release
Categories
(Core :: General, task)
Tracking
()
People
(Reporter: tschuster, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
It might be time to enable this by default. We have had this enabled by default on early-beta for a long time now.
Gabriele Svelto argues that we should just accept the Intel CPU bugs:
FYI we heard nothing from Intel, these kind of bugs have kept popping up and none of the new microcode versions seem to have solved them. I say we should go ahead with our changes. The users of these systems are already having a miserable time and it's better to point them towards getting their machines fixed rather than trying to work around just one of the dozens (!) of different bugs that only ever happen on these CPUs.
Comment 1•8 months ago
|
||
I wonder if we should update our vendored copy to a newer release first.
Comment 2•8 months ago
|
||
Sure.
Comment 3•8 months ago
|
||
As a zlib-rs maintainer I'd recommend upgrading.
| Assignee | ||
Comment 4•8 months ago
|
||
(In reply to Folkert de Vries from comment #3)
As a zlib-rs maintainer I'd recommend upgrading.
Does the ISRG have published audits of the newer versions?
Comment 5•8 months ago
|
||
We've asked them to review the current version. They'll have a look this week.
Comment 6•7 months ago
|
||
Took a little longer, but the audit was made, see https://github.com/divviup/libprio-rs/pull/1415/files. Hopefully that is what you need, let us know if you run into anything.
| Assignee | ||
Comment 7•7 months ago
|
||
Well, looks like we upgraded zlib-rs to 0.6 in bug 2023197 before the audit was done.
| Assignee | ||
Comment 8•7 months ago
|
||
We do keep the option to disable it via USE_LIBZ_RS=, and leave the
remaining zlib support for now because there are still a few things to
untangle, around the fact that some parts are still using zlib instead
of libz-rs.
Updated•7 months ago
|
Comment 10•7 months ago
|
||
| bugherder | ||
Updated•6 months ago
|
Comment 11•6 months ago
|
||
We will revert this from Fx151 release to stem the crashes in Bug 1950764
Comment 12•5 months ago
|
||
https://hg-edge.mozilla.org/releases/mozilla-release/rev/06a703cb9373ae639f21a067b63e732f33460e1b
https://github.com/mozilla-firefox/firefox/commit/5e2efec94a589d866c6b4b716df18c941477c630
Reverted from Fx151 release, to give time for investigation for Bug 1950764
Updated•5 months ago
|
Description
•