Closed Bug 2017549 Opened 9 months ago Closed 7 months ago

Enable libz-rs-sys by default on release

Categories

(Core :: General, task)

task

Tracking

()

RESOLVED FIXED
151 Branch
Tracking Status
firefox151 --- wontfix
firefox152 --- fixed

People

(Reporter: tschuster, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

It might be time to enable this by default. We have had this enabled by default on early-beta for a long time now.

Gabriele Svelto argues that we should just accept the Intel CPU bugs:

FYI we heard nothing from Intel, these kind of bugs have kept popping up and none of the new microcode versions seem to have solved them. I say we should go ahead with our changes. The users of these systems are already having a miserable time and it's better to point them towards getting their machines fixed rather than trying to work around just one of the dozens (!) of different bugs that only ever happen on these CPUs.

bug 1950764 comment 23

See Also: → 1950764

I wonder if we should update our vendored copy to a newer release first.

As a zlib-rs maintainer I'd recommend upgrading.

(In reply to Folkert de Vries from comment #3)

As a zlib-rs maintainer I'd recommend upgrading.

Does the ISRG have published audits of the newer versions?

Flags: needinfo?(flokkievids)

We've asked them to review the current version. They'll have a look this week.

Flags: needinfo?(flokkievids)

Took a little longer, but the audit was made, see https://github.com/divviup/libprio-rs/pull/1415/files. Hopefully that is what you need, let us know if you run into anything.

Well, looks like we upgraded zlib-rs to 0.6 in bug 2023197 before the audit was done.

We do keep the option to disable it via USE_LIBZ_RS=, and leave the
remaining zlib support for now because there are still a few things to
untangle, around the fact that some parts are still using zlib instead
of libz-rs.

Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Pushed by mh@glandium.org: https://github.com/mozilla-firefox/firefox/commit/7faa710c4106 https://hg.mozilla.org/integration/autoland/rev/5008667d6a65 Enable libz-rs-sys by default on release. r=firefox-build-system-reviewers,ahochheiden
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
QA Whiteboard: [qa-triage-done-c152/b151]

We will revert this from Fx151 release to stem the crashes in Bug 1950764

Regressions: 1950764
See Also: 1950764 →
See Also: → 2061973
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: