Closed Bug 2023197 Opened 8 months ago Closed 8 months ago

Upgrade `zlib-rs` crate 0.4.2 → 0.6.3

Categories

(Firefox :: General, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
150 Branch
Tracking Status
firefox150 --- fixed

People

(Reporter: leggert, Assigned: leggert)

References

(Depends on 2 open bugs, Blocks 1 open bug, Regressed 1 open bug)

Details

(Keywords: perf-alert)

Attachments

(2 external files)

Some amd64 and aarch64 improvements have landed since 0.4.2 that would be nice to pick up.

Assignee: nobody → leggert
Pushed by leggert@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/33e5e6afcd99 https://hg.mozilla.org/integration/autoland/rev/486c1c1569a3 Upgrade `zlib-rs` crate to 0.6.3 r=kershaw,supply-chain-reviewers,necko-reviewers

This reverts commit 33e5e6afcd998d8a3ac1084f169862e81d5a6dc8.

:atila, would you have a link to a log so I can look into it?

Flags: needinfo?(abutkovits)
Attachment #9553221 - Attachment description: WIP: Revert "Bug 2023197 - Upgrade `zlib-rs` crate to 0.6.3 for causing bustages in rust.mk. → Revert "Bug 2023197 - Upgrade `zlib-rs` crate to 0.6.3 for causing bustages in rust.mk.
Pushed by leggert@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ae850c588651 https://hg.mozilla.org/integration/autoland/rev/9c36d76f0df4 Upgrade `zlib-rs` crate to 0.6.3 r=kershaw,supply-chain-reviewers,necko-reviewers
Pushed by csabou@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/fa1586887dbc https://hg.mozilla.org/integration/autoland/rev/85f48024aa31 Revert "Bug 2023197 - Upgrade `zlib-rs` crate to 0.6.3 r=kershaw,supply-chain-reviewers,necko-reviewers" for causing linting failures

Backed out for causing linting failures

Push with failures

Failure log

Backout link

We wanted to reland this but other failures popped up so this remains backed out. Filed Bug 2023776 for those rust vendor failures.

Failure logs for which this remains backed out and need to be fixed before relanding:

Flags: needinfo?(leggert)
Flags: needinfo?(leggert)

Sorry for the failures. I can't have treeherder run tests because of the Lando issue...

./mach try chooser
Starting trychooser on http://127.0.0.1:5000
 * Serving Flask app 'tryselect.selectors.chooser.app' (lazy loading)
 * Environment: development
 * Debug mode: off
WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead.
 * Running on http://127.0.0.1:5000
Press CTRL+C to quit
127.0.0.1 - - [17/Mar/2026 13:18:43] "GET / HTTP/1.1" 200 -
127.0.0.1 - - [17/Mar/2026 13:18:43] "GET /static/style.css HTTP/1.1" 304 -
127.0.0.1 - - [17/Mar/2026 13:18:43] "GET /static/filter.js HTTP/1.1" 304 -
127.0.0.1 - - [17/Mar/2026 13:18:43] "GET /static/select.js HTTP/1.1" 304 -
127.0.0.1 - - [17/Mar/2026 13:18:50] "POST / HTTP/1.1" 200 -
127.0.0.1 - - [17/Mar/2026 13:18:50] "GET /static/style.css HTTP/1.1" 304 -
Auth0 token validated.
Using e535ba2be795ac33264c1106f6d98c5ace640f4d as the git base commit.
Submitting 1 node and the try commit.
Patches gathered for submission.
Submitting patches to Lando.
abort: error submitting patches to Lando.
Patch does not match expected format `git-format-patch`: 'utf-8' codec can't decode byte 0x8b in position 313615: invalid start byte
Flags: needinfo?(leggert)

Lars, please join #conduit on matrix to escalate this kind of issues. @shtrom, does this error seem to be on the patch side of things or lando?
Patch does not match expected format git-format-patch: 'utf-8' codec can't decode byte 0x8b in position 313615: invalid start byte

Flags: needinfo?(omehani)
Flags: needinfo?(leggert)

Lars, maybe this helps solve the patch issue when pushing to lando: https://bugzilla.mozilla.org/show_bug.cgi?id=2023776#c2

We are hitting the same issue in three separate spots:

'utf-8' codec can't decode byte 0x8b
  • Patch does not match expected format git-format-patch is a lando-side issue. If this happens when pushing to Try, using the Try support in new Lando (bug 1979247) should fix this issue, e.g.,
LANDO_TRY_CONFIG=lando-prod-new ./mach try...
  • The issue we saw when backing this out was fixed in bug 2023513, and is now in lando-cli 0.4.0
  • The remaining, root cause issue is, I think, due to bug 2023776, where a run of
mach vendor rust --issues-json /builds/worker/issues.json --vcs-diff /builds/worker/vcs-diff.diff
[task 2026-03-17T02:54:24.277+00:00] 

gets the diff of the last commit (judging by the --vcs-diff; which is why it looks intermitent), and chokes on the Unicode in the same way. I think the fix should be in the same ilk, i.e., decode(..., errors="surrogateescape") (https://bugzilla.mozilla.org/show_bug.cgi?id=2023776#c2), but I'm not familiar with that codebase

Flags: needinfo?(omehani)
Depends on: 2023776
Flags: needinfo?(leggert)
Pushed by leggert@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/87afbc916d44 https://hg.mozilla.org/integration/autoland/rev/dfbb73240fbf Upgrade `zlib-rs` crate to 0.6.3 r=kershaw,supply-chain-reviewers,necko-reviewers,devtools-reviewers,places-reviewers,Standard8,bomsy
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch
QA Whiteboard: [qa-triage-done-c151/b150]

(In reply to Pulsebot from comment #15)

Pushed by leggert@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/87afbc916d44
https://hg.mozilla.org/integration/autoland/rev/dfbb73240fbf
Upgrade zlib-rs crate to 0.6.3
r=kershaw,supply-chain-reviewers,necko-reviewers,devtools-reviewers,places-
reviewers,Standard8,bomsy

Perfherder has detected a devtools performance change from push dfbb73240fbf155f3ab511bee12db41761d3f2b7.

No action is required from the author; this comment is provided for informational purposes only.

Improvement Test Platform Options Absolute values [old vs new]
4% damp screenshot.DAMP (doc) linux1804-64-shippable-qr e10s fission stylo webrender 648.72 ms -> 622.58 ms

Need Help or Information?

If you have any questions, please reach out to bacasandrei@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Keywords: perf-alert
Depends on: 2061973
Depends on: 2061975
No longer depends on: 2061975
Regressions: 2061975

Per the discussion on bug 2061973, I don't think this is a regression.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: