2017831 - Trying to create an account that goes to manual config multiple times errors

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Martin Giger [:freaktechnik]]

STR:

• Enter [e-mail] as email address in account hub
• Continue
• Accept the redirect
• Go back after you get the manual config form
• Continue again

The following error should now happen consistently (on the config found subview with the last data it was configured with):

mail.setup: Account setup error: can't access property "source", this[#currentConfig] is null. undefined TypeError: can't access property "source", this[#currentConfig] is null
    #showConfigFoundNotification chrome://messenger/content/accountcreation/views/email.mjs:1858
    #initConfigView chrome://messenger/content/accountcreation/views/email.mjs:1181
    #handleForwardAction chrome://messenger/content/accountcreation/views/email.mjs:836
    handleEvent chrome://messenger/content/accountcreation/views/email.mjs:600
    connectedCallback chrome://messenger/content/accountcreation/views/email.mjs:352
    #loadView chrome://messenger/content/accountcreation/accountHub.js:189
    #viewEmailSetup chrome://messenger/content/accountcreation/accountHub.js:277
    MAIL chrome://messenger/content/accountcreation/accountHub.js:60
    open chrome://messenger/content/accountcreation/accountHub.js:224
    openAccountHub chrome://messenger/content/accountcreation/accountHub.js:335
    openAccountSetup chrome://messenger/content/accountUtils.js:217
    onclick chrome://messenger/content/msgAccountCentral.xhtml?folderURI=mailbox://nobody@Feeds:1
account-hub-header.mjs:107:27

The error is preceded by a guessConfig failed: Error: Can’t find a server and so we should be getting the manual config form with an error in theory. (I think the exchange provider is just aborting requests without auth, which our code treats as "oh, there must be no exchange here")

Comment 1

[Martin Giger [:freaktechnik]]

I think the problem is that we're not checking if config is empty after the #findConfig calls in #redirectAccepted checks. So this affects all email addresses that have a redirect prompt but we can't find any viable config for.

Regression range: https://hg-edge.mozilla.org/comm-central/pushloghtml?fromchange=ba43a351ca1693e3663fba5d5fd4f3484b229d6c&tochange=36750080d223c99d8697215414e207b2e4e4b848

Comment 2

[Vineet Deo]

Attachment: Bug 2017831 - Account Hub: Fix issue where manual config isn't shown after a credentials confirmation. r=#thunderbird-reviewers

How to Test

• Enter [e-mail] as email address in account hub
• Continue
• Accept the redirect
• Go back after you get the manual config form
• Continue again
• Manual config should be shown

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a38471573996
Account Hub: Fix issue where manual config isn't shown after a credentials confirmation. r=freaktechnik