2017919 - Incorrect caching of quad gradients in css/css-tables/tentative/paint/background-image-column.html

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Nicolas Silva [:nical]]

The test fails when precise linear gradients are enabled. The problem is that the cache key for quads does not differentiate between two different sub-rects of the same primitive when the sub-rects have the same size.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 2017919 - Include the device space origin in the cache key. r=gw

Currently it is possible for two sub-rects of the same primitive (or rather two primitives that are deduplicated into the same interning key) to produce the same cache key if their size is exactly the same. This happens with the wpt test css/css-tables/tentative/paint/background-image-column.html.

This patch adds the missing information to the cache key. It's a bit awkward to add it at the top level because non-quads primitives don't need it, but those are going to go away soon and it makes sense to put it next to the size.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1410f36c4ab5
https://hg.mozilla.org/integration/autoland/rev/a10ec1d5430c
Include the device space origin in the cache key. r=gw

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a10ec1d5430c