1978773 - Render gradients from gradient stops directly

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Nicolas Silva [:nical]]

WebRender's gradient shaders work with a fixed size table of something that could be thought of as "quantized evenly-spaced gradient stops". It is very fast to evaluate even when the number of stops is high, but it causes many correctness issues that are fundamentally not fixable using this approach.

In some cases it is because the quantization mises high-frequency details, in other cases it is because it shifts the gradient stops slightly, in a way that is very noticeable for axis-aligned hard stops.

Instead we need a way to render the gradient stops directly in the fragment shader without making any quality compromises, potentially at an extra cost. Hopefully we can offset that cost using one or two fast paths for gradients with few stops.
Skia renders gradients this way, and so should we.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Add a shader that evaluates radial and conic gradients from gradient stops directly. r=#gfx-reviewers

This patch replaces the quad radial and conic gradient shaders with a single shader that can do all css gradients.
The new shader also has a fast path for gradients with no more than two gradient stops: in this configuration, all of the data needed by the fragment shader is passed via varying, which yields significant speedups over reading them from the gpu buffer for each fragment.
The slow path performs a linear search in the gradient stop offsets to find the pair affecting the current pixel. This starts fairly cheap for 4 stops or less as the first 4 stops are also provded via varyings in the slow path, and gets more expensive for each new quadruplet of gradient stops. The assumption here that the vast majority of gradients use less than 8 stops.
In the slow path, once the pair of gradient stop offsets has been computed, the color pair is read from the gpu buffer.

Comment 2

[Robert Longson [:longsonr]]

The vast majority of gradients do use less than 8 stops except when you consider gradients in the linearRGB (or other non-sRGB) color space. To support those colour spaces we add lots of additional gradient stops.

https://searchfox.org/mozilla-central/source/layout/painting/nsCSSRenderingGradients.h#121
https://searchfox.org/mozilla-central/source/layout/painting/nsCSSRenderingGradients.h#53

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Add plumbing to enable/disable the new gradient shader. r=#gfx-reviewers

Comment 4

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Port the new radial gradient code path to SWGL. r=lsalzman

Comment 5

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Use a separate set of gradient prefs for each SWGL and each gradient type. r=lsalzman

That will let us gradually enable it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/91303a1fb111
https://hg.mozilla.org/integration/autoland/rev/280cc8e320b3
Add plumbing to enable/disable the new gradient shader. r=gfx-reviewers,gw
https://github.com/mozilla-firefox/firefox/commit/80071dedf999
https://hg.mozilla.org/integration/autoland/rev/0b56e4ab162d
Use a separate set of gradient prefs for each SWGL and each gradient type. r=lsalzman
https://github.com/mozilla-firefox/firefox/commit/252e4a5f11ff
https://hg.mozilla.org/integration/autoland/rev/7e907d9e1a0b
Add a shader that evaluates radial and conic gradients from gradient stops directly. r=gfx-reviewers,gw
https://github.com/mozilla-firefox/firefox/commit/8decf76f7471
https://hg.mozilla.org/integration/autoland/rev/3d1550a5d48b
Port the new radial gradient code path to SWGL. r=lsalzman

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a481925fd789
https://hg.mozilla.org/integration/autoland/rev/f23322717a45
Revert "Bug 1978773 - Port the new radial gradient code path to SWGL. r=lsalzman" for causing wrench failures

Comment 8

[Cristina Horotan [:chorotan]]

Backed out for causing wrench failure

Backout link

Push with failures

Failure log
Failure log build bustage
Failure log hazard

Comment 9

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Store gradient stop offsets after the colors. r=#gfx-reviewers

This change simplifies the followup patch that will implement a tree traversal of stop offsets.

Comment 10

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Do a tree traversal of gradient stops on the GPU. r=#gfx-reviewers

This patch changes the gradient stop search on the GPU from a linear search to a tree traversal. This drastically reduces the number of gpu buffer reads when there is a lot of gradient stops. An added benefit is that the linear search required non-uniform loop control flow which SWGL currently does not handle (loop that can be exited by some lanes before others). The loop of the tree traversal is uniform which lets SWGL produce correct code.

The tree traversal requires laying out the stops in the gpu buffer in a specific way.

However, the hand-rolled SWGL gradient span shaders benefit enormously from doing an incremental linear search so we keep the linear order of the stops offsets when we know that a span shader will be used.

Comment 11

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Move the dithering code into its own file and integrate it in the precise gradient shader. r=#gfx-reviewers

Comment 12

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Move the dithering code into its own file and integrate it in the precise gradient shader. r=#gfx-reviewers

Comment 13

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Integrate the linear gradient quad path. r=#gfx-reviewers

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e4297e5aebba
https://hg.mozilla.org/integration/autoland/rev/59c8e0aa54c7
Add plumbing to enable/disable the new gradient shader. r=gfx-reviewers,gw
https://github.com/mozilla-firefox/firefox/commit/72a6d8f5d72b
https://hg.mozilla.org/integration/autoland/rev/732ccd085a20
Use a separate set of gradient prefs for each SWGL and each gradient type. r=lsalzman
https://github.com/mozilla-firefox/firefox/commit/7fbd38988847
https://hg.mozilla.org/integration/autoland/rev/f9b3a359e818
Add a shader that evaluates radial and conic gradients from gradient stops directly. r=gfx-reviewers,gw
https://github.com/mozilla-firefox/firefox/commit/1b57776e16c9
https://hg.mozilla.org/integration/autoland/rev/7acb74624df3
Port the new radial gradient code path to SWGL. r=lsalzman
https://github.com/mozilla-firefox/firefox/commit/2681d2487a8d
https://hg.mozilla.org/integration/autoland/rev/4f168e228a41
Store gradient stop offsets after the colors. r=gfx-reviewers,gw
https://github.com/mozilla-firefox/firefox/commit/e56665ebfedc
https://hg.mozilla.org/integration/autoland/rev/dfa179add631
Do a tree traversal of gradient stops on the GPU. r=gfx-reviewers,gw

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/59c8e0aa54c7
https://hg.mozilla.org/mozilla-central/rev/732ccd085a20
https://hg.mozilla.org/mozilla-central/rev/f9b3a359e818
https://hg.mozilla.org/mozilla-central/rev/7acb74624df3
https://hg.mozilla.org/mozilla-central/rev/4f168e228a41
https://hg.mozilla.org/mozilla-central/rev/dfa179add631

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2d20381b352a
https://hg.mozilla.org/integration/autoland/rev/0fd08b4b810a
Move the dithering code into its own file and integrate it in the precise gradient shader. r=gfx-reviewers,lsalzman
https://github.com/mozilla-firefox/firefox/commit/1992b30278a9
https://hg.mozilla.org/integration/autoland/rev/a545ddf93ac7
Integrate the linear gradient quad path. r=gfx-reviewers,gw

Comment 17

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0fd08b4b810a
https://hg.mozilla.org/mozilla-central/rev/a545ddf93ac7

Comment 18

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Adjust outdated comments and rename radius into startRadius. r=lsalzman

• There were a few leftover comments referring to the merge step which is not needed in this version of the shader.
• Removed a few unused variables also orphaned by the absence of the merge step.
• Renamed radius into startRadius

Comment 19

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Fix start_radius taking the wrong input in the swgl span shader. r=#gfx-reviewers

This is already covered by wrench tests and makes them pass with the new (currently preffed off) code path.

Comment 20

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Fix partial chunk steps in the new radial gradient swgl span shader. r=lsalzman

The code was incorrectly assuming that one could simply update dotPos and dotPosDelta for partial chunks by dividing by the chunk size and multiplying by the number of pixels in the partial chunk. That's true for dotPosDelta but not for dotPos where there is a compounding effect with each iteration feeding back into the next in a way that makes things non-linear. There has to be a more elegant solution but after many failed attempts I ended up expressing it in terms of a single-pixel step applied multiple times depending on the number of pixels in the partial chunk. It should be pretty fast still and this way the math looks similar to the whole-chunk steps.

In addition, the patch rounds endT up so that we go all the way to the next pixel that is in a different stop pair rather than stopping one pixel before. This removes a lot of unnecessary partial chunks. Before that, we would round endT down which meant that in the next sub-span we would still be in the same gradient stop pair and advance by a pixel before stepping into the next stop pair.

Comment 21

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Enable precise radial gradients (GPU-only). r=#gfx-reviewers

A followup patch will enable this for SWGL.

Comment 22

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Enable precise radial gradients when using SWGL. r=#gfx-reviewers

Comment 23

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Enable precise conic gradients (GPU-only). r=#gfx-reviewers

A followup patch will enable this for SWGL.

Comment 24

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Enable precise conic gradients when using SWGL. r=#gfx-reviewers

Comment 25

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Enable precise linear gradients (GPU-only). r=#gfx-reviewers

A followup patch will enable this for SWGL.

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/068d1ccc4d12
https://hg.mozilla.org/integration/autoland/rev/e468d20a5154
Adjust outdated comments and rename radius into startRadius. r=lsalzman
https://github.com/mozilla-firefox/firefox/commit/53edbab52298
https://hg.mozilla.org/integration/autoland/rev/e022f593f310
Fix start_radius taking the wrong input in the swgl span shader. r=gfx-reviewers,lsalzman
https://github.com/mozilla-firefox/firefox/commit/ebe39ce25dd1
https://hg.mozilla.org/integration/autoland/rev/39f3130c67c7
Fix partial chunk steps in the new radial gradient swgl span shader. r=lsalzman

Comment 27

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e468d20a5154
https://hg.mozilla.org/mozilla-central/rev/e022f593f310
https://hg.mozilla.org/mozilla-central/rev/39f3130c67c7

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d756df7b53c1
https://hg.mozilla.org/integration/autoland/rev/1b378ce21bd4
Enable precise radial gradients (GPU-only). r=gfx-reviewers,lsalzman

Comment 29

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1b378ce21bd4

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/73689b213ee0
https://hg.mozilla.org/integration/autoland/rev/5b2d92b5ef38
Enable precise radial gradients when using SWGL. r=gfx-reviewers,lsalzman

Comment 31

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5b2d92b5ef38

Comment 32

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Move findGradientStopPair up so it can be used by more functions. r=lsalzman

Comment 33

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Implement the SWGL fast path for precise linear gradients. r=lsalzman"

Comment 34

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Enable precise linear gradients when using SWGL. r=#gfx-reviewers

Comment 35

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Fix validatation of precise gradient addresses. r=lsalzman

The existing function is overly conservative for precise gradients because the latter require less storage per gradient stop.

Comment 36

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/939077064896
https://hg.mozilla.org/integration/autoland/rev/eebb416db3de
Fix validatation of precise gradient addresses. r=lsalzman

Comment 37

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/53c6a9618a3b
https://hg.mozilla.org/integration/autoland/rev/17fb42d96b61
Revert "Bug 1978773 - Fix validatation of precise gradient addresses. r=lsalzman" for causing wrench failures complaining about atomic.h.

Comment 38

[Atila Butkovits]

Backed out for causing wrench failures complaining about atomic.h.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/17fb42d96b619d3d8fc124991d798cf24d0f9c91

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=AeZQaNmjSVKYFwK1fdCPlA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2Copt%2Cwebrender%2Cstandalone%2Cwebrender-linux64-release%2Cwrench&revision=eebb416db3de4a7fe2ebd96884bb8285c95868e8

Failure log: https://treeherder.mozilla.org/logviewer?job_id=530812172&repo=autoland&task=AeZQaNmjSVKYFwK1fdCPlA.0&lineNumber=32818

Comment 39

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/451979278c24
https://hg.mozilla.org/integration/autoland/rev/4f71491003f4
Fix validatation of precise gradient addresses. r=lsalzman

Comment 40

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ffe33fa3dfc6
https://hg.mozilla.org/integration/autoland/rev/8dabcb0cd24d
Enable precise conic gradients (GPU-only). r=gfx-reviewers,lsalzman

Comment 41

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4f71491003f4
https://hg.mozilla.org/mozilla-central/rev/8dabcb0cd24d

Comment 42

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b08bee23dd25
https://hg.mozilla.org/integration/autoland/rev/c3e724e63cae
Enable precise conic gradients when using SWGL. r=gfx-reviewers,lsalzman

Comment 43

[amarc]

https://hg.mozilla.org/mozilla-central/rev/c3e724e63cae

Comment 44

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6ae6008259d9
https://hg.mozilla.org/integration/autoland/rev/2613d5fad715
Move findGradientStopPair up so it can be used by more functions. r=lsalzman
https://github.com/mozilla-firefox/firefox/commit/e55de54f2e2b
https://hg.mozilla.org/integration/autoland/rev/86713b011712
Implement the SWGL fast path for precise linear gradients. r=lsalzman"

Comment 45

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2613d5fad715
https://hg.mozilla.org/mozilla-central/rev/86713b011712

Comment 46

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Temporarily disable precise gradients in SWGL. r=#gfx-reviewers

Precise gradients have a SWGL-specific optimization to speed up the gradient stop lookup. This was implemented in a way that requires SWGL to use the span shader only, since the fallback code uses a different stop representation (the one that works better on GPU but doesn't allow incrementally searching for stops). Unfortunately I discovered late that span shaders are only run on full sized chunks. The Remaining pixels are always going through the (incompatible) fallback. This was caught by tests on the linear gradients but by the time I got to that, radial and conic gradients had already landed.

Until I have a fix for the partial chunk situation, precise gradients will have to be disabled on SWGL.

Comment 47

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Do a tree traversal of gradient stops in SWGL. r=lsalzman

This patch replaces the linear search in the new SWGL gradient paths with the same tree traversal as the GPU version.
The linear version had the advantage of being incremental, so within a span, searches were very fast after the first one. Unfortunately it required the SWGL and GPU paths to use different representations for gradient stop offsets which led to issues when accidentally falling back to the translated glsl code in SWGL.
This version is not incremental so we do the full search each time the span crosses a new gradient stop. This should only matter when the number of gradient stops is high. The tree structure very aggressively converges, though. For example it takes 3 iterations to find a pair in a 124 stops gradient.

Comment 48

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d30a37277899
https://hg.mozilla.org/integration/autoland/rev/9bffbbb5bf29
Temporarily disable precise gradients in SWGL. r=gfx-reviewers,lsalzman

Comment 49

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9bffbbb5bf29

Comment 50

[Nicolas Silva [:nical]]

Comment on attachment 9529020 [details]
Bug 1978773 - Temporarily disable precise gradients in SWGL. r=#gfx-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Incorrect rendering of radial gradients when using software WebRender
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a backout of a recent pref flip. It reverts to well known code paths.
• String changes made/needed:
• Is Android affected?: Yes

Comment 51

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/851822868657
https://hg.mozilla.org/integration/autoland/rev/27892da29335
Do a tree traversal of gradient stops in SWGL. r=lsalzman

Comment 52

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Reenable precise gradients with SWGL. r=#gfx-reviewers

Comment 53

[Donal Meehan [:dmeehan]]

:nical, it's tricky to follow the bug meta data since it's in a leave open state.
Can you confirm only that one pref flip is needed for Fx146?
There is only one beta build left for Fx146 and we go to RC next week

Comment 54

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/27892da29335

Comment 55

[Nicolas Silva [:nical]]

(In reply to Donal Meehan [:dmeehan] from comment #53)

:nical, it's tricky to follow the bug meta data since it's in a leave open state.
Can you confirm only that one pref flip is needed for Fx146?
There is only one beta build left for Fx146 and we go to RC next week

Both gfx.webrender.precise-radial-gradients-swgl and gfx.webrender.precise-conic-gradients-swgl should be set to false in beta.

Comment 56

[Donal Meehan [:dmeehan]]

Comment on attachment 9529020 [details]
Bug 1978773 - Temporarily disable precise gradients in SWGL. r=#gfx-reviewers

Approved for 146.0b9

Comment 57

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/a53b70843e3e
https://hg.mozilla.org/releases/mozilla-beta/rev/b8b41c1a5c32

Comment 58

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/585dadcba78a
https://hg.mozilla.org/integration/autoland/rev/fef66115a015
Reenable precise gradients with SWGL. r=gfx-reviewers,jnicol

Comment 59

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fef66115a015

Comment 60

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Allow quad conic gradients with SWGL. r=#gfx-reviewers

They can be reenabled now that they are cached.

Comment 61

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/837c3a27cf1d
https://hg.mozilla.org/integration/autoland/rev/27f2197fb085
Allow quad conic gradients with SWGL. r=gfx-reviewers,lsalzman

Comment 62

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/27f2197fb085

Comment 63

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2f560ef05ad9
https://hg.mozilla.org/integration/autoland/rev/87b7c8358566
Enable precise linear gradients when using SWGL. r=gfx-reviewers,lsalzman

Comment 64

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f4a44a4ad046
https://hg.mozilla.org/integration/autoland/rev/666db2373586
Revert "Bug 1978773 - Enable precise linear gradients when using SWGL. r=gfx-reviewers,lsalzman" for causing reftest failures on aja-linear-5a.html

Comment 65

[Cristina Horotan [:chorotan]]

Backed out for causing reftest failures on aja-linear-5a.html

Backout link

Push with failures

Failure log

Comment 66

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e95d105ba8f0
https://hg.mozilla.org/integration/autoland/rev/77f105ac1402
Enable precise linear gradients when using SWGL. r=gfx-reviewers,lsalzman

Comment 67

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d9e44cf64349
https://hg.mozilla.org/integration/autoland/rev/b8a3a89d0434
Revert "Bug 1978773 - Enable precise linear gradients when using SWGL. r=gfx-reviewers,lsalzman" for causing unexpected passes on aja-linear-5a.html

Comment 68

[Cosmin Sabou [:CosminS]]

Backed out for causing unexpected passes on aja-linear-5a.html

Push with failures

Failure log

Backout link

Comment 69

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Cache quad linear gradients in some cases. r=gw

Comment 70

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7a78468a72ff
https://hg.mozilla.org/integration/autoland/rev/1a61740dd2e8
Enable precise linear gradients when using SWGL. r=gfx-reviewers,lsalzman

Comment 71

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/1a61740dd2e8

Comment 72

[Alex Finder]

(In reply to Pulsebot from comment #58)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/585dadcba78a
https://hg.mozilla.org/integration/autoland/rev/fef66115a015
Reenable precise gradients with SWGL. r=gfx-reviewers,jnicol

Perfherder has detected a talos performance change from push fef66115a015e98adc6b55259774524a8eb07eed.

No action is required from the author; this comment is provided for informational purposes only.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
8%	rasterflood_gradient	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	1,068.00 -> 1,156.92

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Comment 73

[Nicolas Silva [:nical]]

Attachment: Bug 1978773 - Rename ClipSpace::Raster into ClipSpace::Device. r=gw

This reflects a change that happened in an previous patch in this series.

Comment 74

[Phabricator Automation]

Comment on attachment 9543535 [details]
Bug 1978773 - Rename ClipSpace::Raster into ClipSpace::Device. r=gw

Revision D282387 was moved to bug 1998432. Setting attachment 9543535 [details] to obsolete.

Comment 75

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b44f3f4531ab
https://hg.mozilla.org/integration/autoland/rev/2fc4d6d83319
Cache quad linear gradients in some cases. r=gfx-reviewers,gw

Comment 76

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fd3163957fb5
https://hg.mozilla.org/integration/autoland/rev/844fb16c6ad5
Revert "Bug 1978773 - Cache quad linear gradients in some cases. r=gfx-reviewers,gw" for causing failures at border-gradient-nine-patch.yaml.

Comment 77

[Atila Butkovits]

Backed out for causing failures at border-gradient-nine-patch.yaml.

Backout link: https://hg.mozilla.org/integration/autoland/rev/844fb16c6ad5

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=2fc4d6d833191284da561e9f933f147abca773ad&selectedTaskRun=Hzru5tr5T4OjJywPd0r7Fw.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=548830517&repo=autoland&task=Hzru5tr5T4OjJywPd0r7Fw.0&lineNumber=34184
https://treeherder.mozilla.org/logviewer?job_id=548830793&repo=autoland&task=HfIMmpGWQgqCySvdoTyDDQ.0&lineNumber=2357

Comment 78

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/46ff34e9db4e
https://hg.mozilla.org/integration/autoland/rev/f4b6f82847d7
Cache quad linear gradients in some cases. r=gfx-reviewers,gw

Comment 79

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/40a78dfc3a1f
https://hg.mozilla.org/integration/autoland/rev/b434689e8b86
Revert "Bug 1978773 - Cache quad linear gradients in some cases. r=gfx-reviewers,gw" for causing build bustages

Comment 80

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/b434689e8b862bc3b7f528c1653aced071538478

Push with failures

Failure log -> ERROR - error: no rules expected "gfx.webrender.precise-radial-gradients-swgl"

Comment 81

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5ddbc75edaf1
https://hg.mozilla.org/integration/autoland/rev/c8a931ab2c27
Cache quad linear gradients in some cases. r=gfx-reviewers,gw

Comment 82

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c8a931ab2c27

Comment 83

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0d14d6c52199
https://hg.mozilla.org/integration/autoland/rev/669d87301401
Enable precise linear gradients (GPU-only). r=gfx-reviewers,lsalzman

Comment 84

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/57996 for changes under testing/web-platform/tests

Comment 85

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/669d87301401

Comment 86

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 87

[Daniel Holbert [:dholbert]]

This is leave-open but it looks like all of the patches have landed. Maybe this should be closed as FIXED? (unless backing out turns out to be the fix for regression bug 2019872)

Comment 88

[Nicolas Silva [:nical]]

Indeed. Let's close (and potentially reopen later if I can't figure out the bug 2019872 soon enough).