2018097 - Implement RenderCompositorLayerNative::GetWindowProperties()

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

GetWindowProperties() is not yet implemented in RenderCompositorLayerNative. Without implementing GetWindowProperties(), WebRender layer manager always use only one content layer by WindowProperties::default().

On Wayland, RenderCompositorLayerNative needs to force only one content layer during taking screenshot. There is gdk_paintable_snapshot() for getting screenshot. But it needs to be called in main thread. Then it could not be used for taking screenshot of WebRender layer compositor.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 2018097 - Implement RenderCompositorLayerNative::GetWindowProperties()

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cce955e3fd29
https://hg.mozilla.org/integration/autoland/rev/d799bb572b19
Implement RenderCompositorLayerNative::GetWindowProperties() r=gfx-reviewers,bradwerth

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d799bb572b19

Comment 4

[Martin Stránský [:stransky] (ni? me)]

I don't quite understand what do you mean here but note that gdk_paintable_snapshot() is Gtk4 function and Firefox runs Gtk3.

Comment 5

[Sotaro Ikeda [:sotaro]]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #4)

I don't quite understand what do you mean here but note that gdk_paintable_snapshot() is Gtk4 function and Firefox runs Gtk3.

I just found the api from chromium's implementation. Anyway gtk api is not tried to be used for taking screenshot.