2018860 - WebGL with WebRender layer compositor on Wayland does not use overlay

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

Tested with the following with pref gfx.webrender.layer-compositor = true and pref gfx.webrender.compositor.force-enabled = true.

https://webglsamples.org/aquarium/aquarium.html

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: temporal patch - Add log

Comment 2

[Sotaro Ikeda [:sotaro]]

From Attachment 9547452 [details] [diff], the WebGL image was not on picture surface.

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: temporal patch - Add log

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: temporal patch - Add log

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: temporal patch - Add log

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: temporal patch - Add log

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: temporal patch - Disable rounded clip rect in ApplyOverflowClipping()

Comment 8

[Sotaro Ikeda [:sotaro]]

WebGL was rendered to offscreen surface since stacking context had a complex clip. It was decided in push_stacking_context().

Comment 9

[Sotaro Ikeda [:sotaro]]

With Attachment 9548096 [details] [diff], the problem was addressed. Then rounded clip rect was added by ApplyOverflowClipping(). And the rounded clip rect was set to stacking context.

Comment 10

[Sotaro Ikeda [:sotaro]]

Checked regression range with the following

./mach mozregression --good 2025-11-01 --pref gfx.webrender.debug.picture-borders:true -a https://webglsamples.org/aquarium/aquarium.html

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c652bb4f7aa58ff9a36d67390a64f0495381c66d&tochange=8d54cc2c66e9d90b6f297c017c6294c3c6b30edd

Comment 11

[Sotaro Ikeda [:sotaro]]

:emilio, can you look into this bug? Bug 2005854 fix seemed to cause this bug.

Comment 12

[Emilio Cobos Álvarez [:emilio]]

Seems like the same root cause as bug 2013682, right? If that could be looked into from the graphics team it'd be awesome. I can try but I'm a bit swamped with other things.

Comment 13

[Sotaro Ikeda [:sotaro]]

OK, graphics team is going to look into this bug.

Comment 14

[Sotaro Ikeda [:sotaro]]

Confirmed that the patches in Bug 2013682 addressed the problem for me.

Comment 15

[Sotaro Ikeda [:sotaro]]

Addressed by Bug 2013682 fix.

Comment 16

[Mathew Hodson]

Think this was supposed to be marked fixed same as bug 2013682