Closed Bug 2019097 Opened 6 months ago Closed 5 months ago

Rename arrowpanel tokens to panel

Categories

(Toolkit :: Themes, task, P3)

Product:
Toolkit
Component:
Themes
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
151 Branch
Tracking Flags:
Tracking Status
firefox151 --- fixed

People

(Reporter: jules, Assigned: oarnesto)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp] [acorntractors])

Attachments

(1 file)

Bug 2019097 - Rename `--arrowpanel-*` variables to `--panel-*`, consolidate with `--panel-*` variables in `popup.css`
48 bytes, text/x-phabricator-request
Details | Review

When moving existing panel variables into design tokens, we inherited the 'arrowpanel' name. Visually, our panels no longer have an arrow either (with the exception of onboarding callouts).

Let's rename '--arrowpanel' to '--panel' and clean up any references.

Assignee: nobody → oarnesto
Status: NEW → ASSIGNED
Attachment #9549699 - Attachment description: WIP: Bug 2019097 - Rename `--arrowpanel-*` variables to `--panel-*` r=#reusable-components-reviewers-rotation → Bug 2019097 - Rename `--arrowpanel-*` variables to `--panel-*` r=#reusable-components-reviewers-rotation
Attachment #9549699 - Attachment description: Bug 2019097 - Rename `--arrowpanel-*` variables to `--panel-*` r=#reusable-components-reviewers-rotation → WIP: Bug 2019097 - Rename `--arrowpanel-*` variables to `--panel-*` r=#reusable-components-reviewers-rotation
Attachment #9549699 - Attachment description: WIP: Bug 2019097 - Rename `--arrowpanel-*` variables to `--panel-*` r=#reusable-components-reviewers-rotation → Bug 2019097 - Rename `--arrowpanel-*` variables to `--panel-*` r=#reusable-components-reviewers-rotation
Attachment #9549699 - Attachment description: Bug 2019097 - Rename `--arrowpanel-*` variables to `--panel-*` r=#reusable-components-reviewers-rotation → Bug 2019097 - Rename `--arrowpanel-*` variables to `--panel-*`, rename previous `--panel-*` to `--popup-*` r=#reusable-components-reviewers-rotation
Attachment #9549699 - Attachment description: Bug 2019097 - Rename `--arrowpanel-*` variables to `--panel-*`, rename previous `--panel-*` to `--popup-*` r=#reusable-components-reviewers-rotation → Bug 2019097 - Rename `--arrowpanel-*` variables to `--panel-*`, consolidate with `--panel-*` variables in `popup.css`
Pushed by oarnesto@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/2348af85be00 https://hg.mozilla.org/integration/autoland/rev/3bd259006b65 Rename `--arrowpanel-*` variables to `--panel-*`, consolidate with `--panel-*` variables in `popup.css` r=desktop-theme-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,urlbar-reviewers,Standard8,aminomancer,sthompson,dao,devtools-reviewers,nchevobbe

https://hg.mozilla.org/mozilla-central/rev/3bd259006b65

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox151: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
Blocks: 2031127
Regressions: 2031202
Regressions: 2031931
Regressions: 2033327
QA Whiteboard: [qa-triage-done-c152/b151]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: