1826841 - Update panel-list and panel-item to match the menu spec, use design tokens

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, enhancement)

Description

[Mark Striemer [:mstriemer]]

We have a spec for menus [1] that seems like it was mostly intended for chrome but it would likely make sense to update panel-menu to follow that spec for in-content as well.

We should be able to update the styles to use design tokens while we do this. The panel- and button-*-menu tokens should suffice, but if we do need some tokens they should go in panel-list.tokens.json and be matched up with Figma for any Nova variants needed

Nova panel Figma is most up to date

Comment 1

[Dão Gottwald [:dao]]

Heads-up that bug 1998985 will make us use panel-list for the address bar's and search bar's search engine button dropdown menus, so panel-list would appear in a fairly prominent place in primary UI where more folks might notice that panel-list looks and feels not quite like our other more native menus. I imagine that might elevate this bug's priority, although from what I can see this bug is already well on your radar. :)

Comment 3

[Jon Oliver]

Attachment: Bug 1826841 - update panel-list and panel-item to match menu spec r=#desktop-theme-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ca00978cc594
https://hg.mozilla.org/integration/autoland/rev/f81147c26319
update panel-list and panel-item to match menu spec r=desktop-theme-reviewers,hjones,gcardieri

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/527815c83e27
https://hg.mozilla.org/integration/autoland/rev/bcd5be984722
Revert "Bug 1826841 - update panel-list and panel-item to match menu spec r=desktop-theme-reviewers,hjones,gcardieri" for causing node failures

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing node failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/bcd5be9847224a06b80cfbe6f7f6df544a4362e1

Push with failures

Failures log -> TEST-UNEXPECTED-FAIL | undefined | Mixed shorthand values should be fixed to use design tokens where possible. | Warning "message" does not match

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ffb01a29ee29
https://hg.mozilla.org/mozilla-central/rev/a1f18f6f2418
update panel-list and panel-item to match menu spec r=desktop-theme-reviewers,hjones,gcardieri

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a1f18f6f2418