2019153 - Add border radius to text selection in the urlbar input for Nova

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Drew Willcoxon :adw]

The Nova design calls for a border radius on text selection in the urlbar input. I don't know if that's even possible. Paul said if it's not, it's OK. We may need Gecko support.

See Figma for details.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 2019153: Round the selection highlight for the urlbar input field

This change implements the rounded selection highlight used in the new Nova
design for the urlbar. [1]

For configuration, this implementation targets only chrome-privileged text
controls. If the moz-selection-radius attribute is set on a text control
element, its float value is used as the corner radius of the selection highlight.

For example:
<html:input id="urlbar-input" moz-selection-radius="4" />

Alternative approaches such as introducing a CSS property or using a pref were
considered. However:

1. This styling is intended only for Firefox UI (not web content).
2. It may be reused by other internal Firefox components in the future.

Based on these considerations, I chose to use an attribute.

[1] https://www.figma.com/design/WMHwWMwIu6SDzJyvVUn33X/S-S-UX-Specifications–Sprint-2-?node-id=13056-9952&t=pswCcokl3etqlyZU-1

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/14efb900d974
https://hg.mozilla.org/integration/autoland/rev/843bf3f6acd8
Round the selection highlight for the urlbar input field r=layout-reviewers,adw,emilio,desktop-theme-reviewers,firefox-style-system-reviewers

Comment 3

[rperta]

https://hg.mozilla.org/mozilla-central/rev/843bf3f6acd8

Comment 4

[Petruta Horea [:phorea]]

Verified as fixed using latest Nightly 151.0a1 under Win 11, Ubuntu 24 and macOS 15 while browser.urlbar.nova.featureGate was set to True.
The selection highlight for the urlbar input field is now rounded.

Comment 5

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2050759