2029839 - Consider unifying fallback color and background-color logic for ::selection, ::target-text, and custom highlights

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task)

Description

[Daisuke Akatsuka (:daisuke)]

Currently, there are three separate code paths in nsTextPaintStyle that determine whether to use native selection colors or author-specified ones:

1. Web content ::selection (existing path in nsTextPaintStyle.cpp)
2. Chrome-privileged ::selection (introduced in bug 2019153, using HasAuthorSpecifiedTextColor() || NS_GET_A(bgColor) > 0)
3. ::target-text

Ideally, these should share consistent fallback logic.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2029839 - More consistent selection color drawing. r=jjaschke,#layout

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/753827d74982
https://hg.mozilla.org/integration/autoland/rev/6713e94ce05b
More consistent selection color drawing. r=jjaschke

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6e9f55be19cf
https://hg.mozilla.org/integration/autoland/rev/707b4682cf30
Annotate some tests in macOS and Android.

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6713e94ce05b
https://hg.mozilla.org/mozilla-central/rev/707b4682cf30