Closed Bug 2019163 Opened 6 months ago Closed 1 month ago

Update icon spacing in urlbar quick actions for Nova

Categories

(Firefox :: Address Bar, task, P1)

task

Tracking

()

VERIFIED FIXED
154 Branch
Tracking Status
firefox154 --- verified

People

(Reporter: adw, Assigned: adw)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sng][nova-search])

Attachments

(1 file)

Update the quick actions UI in the urlbar view for Nova:

  • Colors
  • Rounded edges

See Figma for details.

Whiteboard: [sng] → [sng][nova-search]
Priority: P2 → P1

The Components Figma uses the urlbarview/action/button/background/color group of tokens for actions with two possible states: default and hover. Those tokens don't seem to exist in m-c, but we do have a bespoke urlbar CSS variable for --urlbarView-action-button-background-color.

I've asked Jules about what we should do in cases like this and will update when I hear back.

Jules's patch in bug 2046942 fixes the main thing: background color (per state).

The only other thing that looks different to me is the spacing between the icon and text is a little too tight in code. We use 0.4em in code, and the Figma uses 8px, which ends up being larger, although it will vary a little per platform.

The rounded edges mentioned in comment 0 were fixed a while ago by some other patch.

Depends on: 2046942
Assignee: nobody → adw
Status: NEW → ASSIGNED

The Figma uses a literal 8px but it seems better to use a space variable.
--space-medium matches 8px pretty well. On Windows 11 with standard scaling,
it ends up being 9px. On Mac, it's 8x, although it slightly changes the subpixel
rendering of the quick action's text compared to a hardcoded 8px.

I'm basing this on D306443 so that Jules doesn't need to rebase that large
patch.

Depends on D306443

Morphing this to cover only the icon spacing since bug 2046942 covers everything else afaict.

Summary: Update the quick actions UI in the urlbar view for Nova → Update icon spacing in urlbar quick actions for Nova
Pushed by dwillcoxon@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/2234f06621cb https://hg.mozilla.org/integration/autoland/rev/79ab1143ed93 [Nova] Update icon spacing in urlbar quick actions. r=dao,desktop-theme-reviewers,urlbar-reviewers

For QA: This bug didn't do much visually, just slightly increased the spacing in quick actions between the icon and text.

Flags: qe-verify+
Flags: in-testsuite-
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
QA Whiteboard: [search][qa-triage-done-c154/b153][qa-ver-needed-c154/b153]

Verified using latest Nightly 154.0a1 2026-07-06 under Win 11, macOS 15 and Ubuntu 24, that when Nova is enabled, the space between icon and text is increased in Quick Actions.

Status: RESOLVED → VERIFIED
QA Whiteboard: [search][qa-triage-done-c154/b153][qa-ver-needed-c154/b153] → [search][qa-triage-done-c154/b153][qa-ver-done-c154/b153]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: