Closed Bug 2046942 Opened 2 months ago Closed 1 month ago

Make sure urlbar and tab Nova files are syncing with Figma

Categories

(Toolkit :: Themes, task, P3)

task

Tracking

()

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: jules, Assigned: jules)

References

(Blocks 4 open bugs, Regressed 1 open bug)

Details

(Whiteboard: [recomp-nova])

Attachments

(1 file)

We kicked off the Novafying of tab and urlbar with some manually created json files. We have a script to sync with Figma and auto generate these files, so we should make sure it is syncing with Figma so we don't have to manually update tokens.

Blocks: nova-urlbar
Blocks: 2045988
Blocks: 2045993
Duplicate of this bug: 2039722
Blocks: 2019163
Blocks: 2043079
Whiteboard: [recomp-nova]
Attachment #9596930 - Attachment description: WIP: Bug 2046942 - Make sure urlbar and tab Nova files are syncing with Figma → Bug 2046942 - Make sure urlbar and tab Nova files are syncing with Figma
Blocks: 2050360
Blocks: 2050395
Blocks: 2052926
Blocks: 2052924
Pushed by jsimplicio@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/9bb3555c1667 https://hg.mozilla.org/integration/autoland/rev/5909f31b8320 Make sure urlbar and tab Nova files are syncing with Figma r=dao,desktop-theme-reviewers,tabbrowser-reviewers,urlbar-reviewers,akulyk,nsharpley
Pushed by pstanciu@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/c9f4bdf1444e https://hg.mozilla.org/integration/autoland/rev/6e965b6bb21a Revert "Bug 2046942 - Make sure urlbar and tab Nova files are syncing with Figma r=dao,desktop-theme-reviewers,tabbrowser-reviewers,urlbar-reviewers,akulyk,nsharpley" for causing node spm failures
Pushed by jsimplicio@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/54b77c339f03 https://hg.mozilla.org/integration/autoland/rev/88c6bb02c3de Make sure urlbar and tab Nova files are syncing with Figma r=dao,desktop-theme-reviewers,tabbrowser-reviewers,urlbar-reviewers,akulyk,nsharpley
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
Flags: needinfo?(jules)
Regressions: 2057443
QA Whiteboard: [qa-triage-done-c155/b154]
Regressions: 2054329
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: