Closed
Bug 2046942
Opened 2 months ago
Closed 1 month ago
Make sure urlbar and tab Nova files are syncing with Figma
Categories
(Toolkit :: Themes, task, P3)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
154 Branch
| Tracking | Status | |
|---|---|---|
| firefox154 | --- | fixed |
People
(Reporter: jules, Assigned: jules)
References
(Blocks 4 open bugs, Regressed 1 open bug)
Details
(Whiteboard: [recomp-nova])
Attachments
(1 file)
We kicked off the Novafying of tab and urlbar with some manually created json files. We have a script to sync with Figma and auto generate these files, so we should make sure it is syncing with Figma so we don't have to manually update tokens.
| Assignee | ||
Comment 1•2 months ago
|
||
Updated•2 months ago
|
Blocks: nova-urlbar
| Assignee | ||
Updated•2 months ago
|
Whiteboard: [recomp-nova]
Updated•2 months ago
|
Updated•2 months ago
|
Attachment #9596930 -
Attachment description: WIP: Bug 2046942 - Make sure urlbar and tab Nova files are syncing with Figma → Bug 2046942 - Make sure urlbar and tab Nova files are syncing with Figma
Blocks: nova-foxfooding
Pushed by jsimplicio@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/9bb3555c1667
https://hg.mozilla.org/integration/autoland/rev/5909f31b8320
Make sure urlbar and tab Nova files are syncing with Figma r=dao,desktop-theme-reviewers,tabbrowser-reviewers,urlbar-reviewers,akulyk,nsharpley
Pushed by pstanciu@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/c9f4bdf1444e
https://hg.mozilla.org/integration/autoland/rev/6e965b6bb21a
Revert "Bug 2046942 - Make sure urlbar and tab Nova files are syncing with Figma r=dao,desktop-theme-reviewers,tabbrowser-reviewers,urlbar-reviewers,akulyk,nsharpley" for causing node spm failures
Backed out for causing node spm failures
Flags: needinfo?(jules)
Pushed by jsimplicio@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/54b77c339f03
https://hg.mozilla.org/integration/autoland/rev/88c6bb02c3de
Make sure urlbar and tab Nova files are syncing with Figma r=dao,desktop-theme-reviewers,tabbrowser-reviewers,urlbar-reviewers,akulyk,nsharpley
Comment 7•1 month ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox154:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
| Assignee | ||
Updated•1 month ago
|
Flags: needinfo?(jules)
Updated•1 month ago
|
QA Whiteboard: [qa-triage-done-c155/b154]
You need to log in
before you can comment on or make changes to this bug.
Description
•