2019258 - Extend the CSSContainerRule interface to support a list of conditions

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Jonathan Kew [:jfkthame]]

The CSSContainerRule interface needs to be extended to support a list of conditions, as the spec calls for @container rules to accept a comma-separated list of conditions, not just a single condition. See bug 2016929 comment 2 and https://github.com/w3c/csswg-drafts/issues/10845.

Once the spec issue is resolved, we should implement (and add tests for) the extended behavior.

Comment 1

[Emily McDonough [:alaskanemily]]

ni for emilio about the spec issue https://github.com/w3c/csswg-drafts/issues/10845

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Wdyt about something like https://github.com/w3c/csswg-drafts/pull/13635?

Comment 3

[Emily McDonough [:alaskanemily]]

That looks fine. I have a change to the Servo code to support this partially done. I can build the last part (serialization/interface to Gecko) based on the code in bug 2022827, no matter what the resolution is the actual code will have to at least have that general shape.

Comment 4

[Emily McDonough [:alaskanemily]]

Attachment: Bug 2019258 Part 1 - Use derived/generated to_css for ContainerCondition

Comment 5

[Emily McDonough [:alaskanemily]]

Attachment: Bug 2019258 Part 2 - Change to using a list of conditions for Servo ContainerRule

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/681754225fd5
https://hg.mozilla.org/integration/autoland/rev/a8d7246cd5fa
Part 1 - Use derived/generated to_css for ContainerCondition r=firefox-style-system-reviewers,emilio
https://github.com/mozilla-firefox/firefox/commit/29a7a013d1ee
https://hg.mozilla.org/integration/autoland/rev/391f3cecaaaf
Part 2 - Change to using a list of conditions for Servo ContainerRule r=firefox-style-system-reviewers,emilio

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a8d7246cd5fa
https://hg.mozilla.org/mozilla-central/rev/391f3cecaaaf