2022827 - Implement CSSContainerRule.conditions

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2022827 - Implement CSSContainerRule.conditions. r=alaskanemily!,#webidl!

As per https://github.com/w3c/csswg-drafts/pull/13635. To be landed once
there's a resolution and so on.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Needs tests too of course.

Comment 3

[Emily McDonough [:alaskanemily]]

For quickly making up some tests, I think the cases from the WPT for comma-separated queries could be reused to start.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ede0eccbeb8a
https://hg.mozilla.org/integration/autoland/rev/89c6e5274681
Implement CSSContainerRule.conditions. r=AlaskanEmily,webidl,smaug

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/58764 for changes under testing/web-platform/tests

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/89c6e5274681

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[Sebastian Zartner [:sebo]]

[Why is this notable]: New API replacing existing API
[Affects Firefox for Android]: yes
[Suggested wording]: A new CSSContainerRule.conditions property got introduced holding an array of all container query conditions. This new property is meant to replace CSSContainerRule.containerName and CSSContainerRule.containerQuery, which only supported a single name and query, making them obsolete.
[Links (documentation, blog post, etc)]:
https://groups.google.com/a/mozilla.org/g/dev-platform/c/9NsbuM3nfoI/m/1HWO7dhDAAAJ

This change goes hand in hand with support for multiple comma-separated conditions in @container, which is implemented in bug 2019254. So when that lands, maybe both should be combined in a single release note.

Sebastian

Comment 9

[Donal Meehan [:dmeehan]]

Added to the Fx151 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx151 release notes.

Comment 10

[Donal Meehan [:dmeehan]]

Added to the final Fx151 release notes

Comment 11

[Hamish Willee]

FF151 MDN docs work for this tracked in https://github.com/mdn/content/issues/43864 (complete, being reviewed)