2019651 - Add "Dismiss" command to the result menu for URL autofill results

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[James Teow [:jteow]]

• Implement getResultCommands() on UrlbarProviderAutofill
• Implement onEngagement() on UrlbarProviderAutofill
• Add dismiss support to origin autofill results
• Add browser tests for dismiss

The options should be guarded by the adaptive autofill pref.

Comment 1

[James Teow [:jteow]]

Attachment: Bug 2019651 - Add dismiss command to the result menu for adaptive autofill results - r?#urlbar-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bb637c9e84ee
https://hg.mozilla.org/integration/autoland/rev/213834f45d88
Add dismiss command to the result menu for adaptive autofill results - r=urlbar-reviewers,mak

Comment 3

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitests failures in browser_autoFill_resultMenu_dismissal.js.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_autoFill_resultMenu_dismissal.js | reintegration_origins_autofill - Uncaught exception in test - Error: Menu item not found for command: dismiss_origin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5994aed6ac2d
https://hg.mozilla.org/integration/autoland/rev/5b2e3ef34725
Add dismiss command to the result menu for adaptive autofill results - r=urlbar-reviewers,mak

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/5b2e3ef34725