2028730 - Hide dismiss autofill menu item in private browsing mode

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[James Teow [:jteow]]

The adaptive autofill result menu currently shows a "Dismiss" option in PBM.

Since dismissals write a block timestamp to the Places database (which persists across sessions) but re-integration isn't enabled for PBM (nor backspace blocking), it doesn't make sense to offer this action in private browsing. The "Remove from history" option should still appear for non-origin adaptive URL results, since that action is available for regular history results in private browsing.

Comment 1

[James Teow [:jteow]]

Attachment: Bug 2028730 - Hide dismiss autofill menu item in private browsing mode - r?mak!

This patch passes isPrivate from the query context to getResultCommands() in
the autofill provider and suppresses the dismiss_autofill command when in
a private browsing context. If no commands remain (e.g. for origin results
in PBM), the provider returns undefined so no menu button is shown.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9e1dbd865514
https://hg.mozilla.org/integration/autoland/rev/296f03dabfe4
Hide dismiss autofill menu item in private browsing mode - r=urlbar-reviewers,mak

Comment 3

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/296f03dabfe4