2019934 - Render images using quad shaders in simple cases

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Nicolas Silva [:nical]]

The image primitive is WebRender's most complex primitive (surprisingly), due to the many combination of special cases it has to handle, so this bug focuses on porting the simple cases to quad shaders (non-tiled, non-external, and without some of the special logic to handle stacking context snapshots).

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 2019934 - Pass the color/texture mode explicitly to the textured quad shader. r=gw

We have bit to spare in the pattern inputs, that seems a bit less error prone to me.

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 2019934 - Allow the textured quad shader to map to either segment or prim bounds. r=gw

The textured quad shader is currently only used to composite indirect primitives with a render task per segment.
Once we start segmenting actual image primitives, we need the segments to point to sub-parts of the source image instead of showing the whole image for each segment.

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 2019934 - Use the ps_quad_textured shader for image primitives in simple cases. r=gw

Comment 4

[Nicolas Silva [:nical]]

Attachment: Bug 2019934 - Fix incorrect repeated UVs when there is tile spacing. r=gw

Comment 5

[Nicolas Silva [:nical]]

Attachment: Bug 2019934 - Skip an intermediate pass if the source of the repeat shader is already a render task. r=gw

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/45854b4101a4
https://hg.mozilla.org/integration/autoland/rev/713625d25f1e
Fix incorrect repeated UVs when there is tile spacing. r=gw
https://github.com/mozilla-firefox/firefox/commit/297472668aba
https://hg.mozilla.org/integration/autoland/rev/d74ac6f646e1
Pass the color/texture mode explicitly to the textured quad shader. r=gw
https://github.com/mozilla-firefox/firefox/commit/c9c5a2c8cd39
https://hg.mozilla.org/integration/autoland/rev/88630521422d
Allow the textured quad shader to map to either segment or prim bounds. r=gw

Comment 7

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/713625d25f1e
https://hg.mozilla.org/mozilla-central/rev/d74ac6f646e1
https://hg.mozilla.org/mozilla-central/rev/88630521422d

Comment 8

[Nicolas Silva [:nical]]

Attachment: Bug 2019934 - Make getting the source texture of a quad primitive fallible. r=gw

This is needed for stacking context snapshots which are fallible. This matches the behavior of the brush image primitive.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f360d9be5c11
https://hg.mozilla.org/integration/autoland/rev/c87b20c30085
Use the ps_quad_textured shader for image primitives in simple cases. r=gw
https://github.com/mozilla-firefox/firefox/commit/97a5d7520802
https://hg.mozilla.org/integration/autoland/rev/2feb197e5d75
Skip an intermediate pass if the source of the repeat shader is already a render task. r=gw
https://github.com/mozilla-firefox/firefox/commit/48de01771025
https://hg.mozilla.org/integration/autoland/rev/8bd9cac121c1
Make getting the source texture of a quad primitive fallible. r=gw

Comment 10

[Silaghi Andreea]

Backed out for causing wrench build bustages
Backout Link
Push with failures
Failure Log
Failure line REFTEST TEST-UNEXPECTED-FAIL | reftests\gradient\linear-hard-stop-repeat-large.yaml == reftests\gradient\linear-hard-stop-repeat-large-ref.yaml | image comparison, max difference: 1, number of differing pixels: 8200 | 8200 num_differences > 0 and <= 255 (allowed 0);

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/414c1db7cfe0
https://hg.mozilla.org/integration/autoland/rev/73cda4111360
Use the ps_quad_textured shader for image primitives in simple cases. r=gw
https://github.com/mozilla-firefox/firefox/commit/010f94e29173
https://hg.mozilla.org/integration/autoland/rev/fad23a9f3b7d
Skip an intermediate pass if the source of the repeat shader is already a render task. r=gw
https://github.com/mozilla-firefox/firefox/commit/af35545ad187
https://hg.mozilla.org/integration/autoland/rev/2ec897451731
Make getting the source texture of a quad primitive fallible. r=gw

Comment 12

[rperta]

Backed out for causing wr failures at iframe-and-main-frame-transition-old-main-new-iframe.html
Backout link
Push with failures
Failure log(s)

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/381499a3aaa5
https://hg.mozilla.org/integration/autoland/rev/556a8c777456
Use the ps_quad_textured shader for image primitives in simple cases. r=gw
https://github.com/mozilla-firefox/firefox/commit/fe695188a69d
https://hg.mozilla.org/integration/autoland/rev/fdfd4fe4f7f9
Skip an intermediate pass if the source of the repeat shader is already a render task. r=gw
https://github.com/mozilla-firefox/firefox/commit/d2f94fc0cc27
https://hg.mozilla.org/integration/autoland/rev/b51b8fd361dc
Make getting the source texture of a quad primitive fallible. r=gw

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d25a4a3a5d6e
https://hg.mozilla.org/integration/autoland/rev/9079bc9abf21
metadata update

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fa9ee374b8ff
https://hg.mozilla.org/integration/autoland/rev/1e00415c84d6
Revert "Bug 2019934, Bug 2020923 - metadata update" for causing wpt-meta failures at list-box-important-colors.html.ini

Comment 16

[rperta]

Backed out for causing wpt-meta failures at list-box-important-colors.html.ini
Backout link
Push with failures
Failure log(s)

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3de245cb7f4d
https://hg.mozilla.org/integration/autoland/rev/c062a1818445
Use the ps_quad_textured shader for image primitives in simple cases. r=gw
https://github.com/mozilla-firefox/firefox/commit/e0759e6d26a0
https://hg.mozilla.org/integration/autoland/rev/2c08d2d38550
Skip an intermediate pass if the source of the repeat shader is already a render task. r=gw
https://github.com/mozilla-firefox/firefox/commit/1955409541e2
https://hg.mozilla.org/integration/autoland/rev/2eb23b5aa59d
Make getting the source texture of a quad primitive fallible. r=gw

Comment 18

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitests failures in browser_bug295977_autoscroll_overflow.js.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/content/tests/browser/browser_bug295977_autoscroll_overflow.js | Failed: e should have scrolled vertically

Comment 19

[amarc]

please also address the failure in bug 2022950, and these:
https://treeherder.mozilla.org/logviewer?job_id=553265401&repo=autoland&task=bz9V4ujNRm6lGFqcseD5kw.0
https://treeherder.mozilla.org/logviewer?job_id=553265925&repo=autoland&task=OB6k1l1YR9SqpnlxKZI48A.0

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1f3f27070239
https://hg.mozilla.org/integration/autoland/rev/8a977a4cf99e
Skip an intermediate pass if the source of the repeat shader is already a render task. r=gw
https://github.com/mozilla-firefox/firefox/commit/1d5a40e48cc3
https://hg.mozilla.org/integration/autoland/rev/688f49e7c931
Make getting the source texture of a quad primitive fallible. r=gw

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0bce9032bb54
https://hg.mozilla.org/integration/autoland/rev/8dcee978f14f
Skip an intermediate pass if the source of the repeat shader is already a render task. r=gw
https://github.com/mozilla-firefox/firefox/commit/f3df5934eaa7
https://hg.mozilla.org/integration/autoland/rev/dabe168238e6
Make getting the source texture of a quad primitive fallible. r=gw

Comment 22

[amarc]

https://hg.mozilla.org/mozilla-central/rev/8dcee978f14f
https://hg.mozilla.org/mozilla-central/rev/dabe168238e6

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/462c43071492
https://hg.mozilla.org/integration/autoland/rev/d0fbc1138701
Use the ps_quad_textured shader for image primitives in simple cases. r=gw

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/403431c6882c
https://hg.mozilla.org/integration/autoland/rev/2b20bfa2ea0f
Revert "Bug 2019934 - Use the ps_quad_textured shader for image primitives in simple cases. r=gw" for causing web failures at content-counter-016.xht

Comment 25

[Silaghi Andreea]

Backout for causing web failures at content-counter-000-ref.xht
Backout link
Push with failure
Failure log
Failure line TEST-UNEXPECTED-FAIL | /css/CSS2/generated-content/content-counter-016.xht | Testing http://web-platform.test:8000/css/CSS2/generated-content/content-counter-016.xht == http://web-platform.test:8000/css/CSS2/generated-content/content-counter-000-ref.xht

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/876e94fd7eb9
https://hg.mozilla.org/integration/autoland/rev/09ac39104443
Use the ps_quad_textured shader for image primitives in simple cases. r=gw

Comment 27

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/09ac39104443

Comment 28

[Florin Bilt]

(In reply to Serban Stanca [:SerbanS] from comment #27)

https://hg.mozilla.org/mozilla-central/rev/09ac39104443

Perfherder has detected a mozperftest performance change from push 09ac39104443a664cd22ee61e510aad4b77453d1.

No action is required from the author; this comment is provided for informational purposes only.

Improvement	Test	Platform	Options	Absolute values [old vs new]
4%	tab-restore-shopify org.mozilla.fenix:gpu-cpu-time	android-hw-a55-14-0-aarch64-shippable		693.79 ms -> 663.00 ms
4%	shopify-applink-startup org.mozilla.fenix:gpu-cpu-time	android-hw-a55-14-0-aarch64-shippable		732.83 ms -> 703.50 ms

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Comment 29

[Alex Finder]

(In reply to Pulsebot from comment #26)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/876e94fd7eb9
https://hg.mozilla.org/integration/autoland/rev/09ac39104443
Use the ps_quad_textured shader for image primitives in simple cases. r=gw

Perfherder has detected a browsertime performance change from push 09ac39104443a664cd22ee61e510aad4b77453d1.

No action is required from the author; this comment is provided for informational purposes only.

Improvement	Test	Platform	Options	Absolute values [old vs new]
3%	google-search-restaurants LastVisualChange (doc)	android-hw-a55-14-0-aarch64-shippable	cold webrender	792.90 ms -> 772.39 ms

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.