2020923 - Remove remaining usage of non-quad gradients

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 2020923 - Disable the remaining use of non-quad linear gradients. r=gw

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 2020923 - Fix some repeated patterns incorrectly treated as opaque. r=gw

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 2020923 - Avoid referring to clips across iframes in a wrench test. r=gw

Comment 4

[Nicolas Silva [:nical]]

Attachment: Bug 2020923 - Remove the CachedLinearGradient primitive. r=gw

Quad linear gradients (cached and non-cached) are handled by the regular LinearGradient primitive.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bd25994108fb
https://hg.mozilla.org/integration/autoland/rev/10735a085e48
Disable the remaining use of non-quad linear gradients. r=gw
https://github.com/mozilla-firefox/firefox/commit/87dbc7ca994c
https://hg.mozilla.org/integration/autoland/rev/6dce20c2c989
Fix some repeated patterns incorrectly treated as opaque. r=gw
https://github.com/mozilla-firefox/firefox/commit/e066d3647cf7
https://hg.mozilla.org/integration/autoland/rev/254ca37bae51
Avoid referring to clips across iframes in a wrench test. r=gw

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/668024bc6cab
https://hg.mozilla.org/integration/autoland/rev/fb1200f9296c
Revert "Bug 2020923, Bug 2019934 - Avoid referring to clips across iframes in a wrench test. r=gw" for causing wrench build bustages

Comment 7

[Silaghi Andreea]

Backed out for causing wrench build bustages
Backout Link
Push with failures
Failure Log
Failure line REFTEST TEST-UNEXPECTED-FAIL | reftests\gradient\linear-hard-stop-repeat-large.yaml == reftests\gradient\linear-hard-stop-repeat-large-ref.yaml | image comparison, max difference: 1, number of differing pixels: 8200 | 8200 num_differences > 0 and <= 255 (allowed 0);

Comment 8

[Nicolas Silva [:nical]]

Attachment: Bug 2020923 - Make the repetition iterator more NaN-proof. r=#gfx-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/77d609a90861
https://hg.mozilla.org/integration/autoland/rev/1738bb6f26d6
Disable the remaining use of non-quad linear gradients. r=gw
https://github.com/mozilla-firefox/firefox/commit/8e5b9933cb3f
https://hg.mozilla.org/integration/autoland/rev/3769a9a3eb5d
Fix some repeated patterns incorrectly treated as opaque. r=gw
https://github.com/mozilla-firefox/firefox/commit/5d0ae1481533
https://hg.mozilla.org/integration/autoland/rev/fcdbea2fcfe5
Avoid referring to clips across iframes in a wrench test. r=gw
https://github.com/mozilla-firefox/firefox/commit/1dba8d69e747
https://hg.mozilla.org/integration/autoland/rev/ea3548aeb57d
Make the repetition iterator more NaN-proof. r=gfx-reviewers,lsalzman

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ab474eaf264b
https://hg.mozilla.org/integration/autoland/rev/bfb7fbeeb0a3
Revert "Bug 2020923, Bug 2019934 - Make the repetition iterator more NaN-proof. r=gfx-reviewers,lsalzman" for causing wr failures at iframe-and-main-frame-transition-old-main-new-iframe.html

Comment 11

[rperta]

Backed out for causing wr failures at iframe-and-main-frame-transition-old-main-new-iframe.html
Backout link
Push with failures
Failure log(s)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7332426ef13b
https://hg.mozilla.org/integration/autoland/rev/9ea64959f03e
Disable the remaining use of non-quad linear gradients. r=gw
https://github.com/mozilla-firefox/firefox/commit/9e52c7e02dcd
https://hg.mozilla.org/integration/autoland/rev/2abe4b23a0a0
Fix some repeated patterns incorrectly treated as opaque. r=gw
https://github.com/mozilla-firefox/firefox/commit/8f07552ed441
https://hg.mozilla.org/integration/autoland/rev/3a356451ff52
Avoid referring to clips across iframes in a wrench test. r=gw
https://github.com/mozilla-firefox/firefox/commit/8c8b767491e1
https://hg.mozilla.org/integration/autoland/rev/ef9d8ae4b8d8
Make the repetition iterator more NaN-proof. r=gfx-reviewers,lsalzman

Comment 13

[rperta]

Backed out for causing wpt-meta failures at list-box-important-colors.html.ini
Backout link
Push with failures
Failure log(s)

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9affbe9ccf2b
https://hg.mozilla.org/integration/autoland/rev/f525bb97c2af
Disable the remaining use of non-quad linear gradients. r=gw
https://github.com/mozilla-firefox/firefox/commit/3ae4b392f372
https://hg.mozilla.org/integration/autoland/rev/a78b9ab64148
Fix some repeated patterns incorrectly treated as opaque. r=gw
https://github.com/mozilla-firefox/firefox/commit/d88db76427ed
https://hg.mozilla.org/integration/autoland/rev/25f399947e38
Avoid referring to clips across iframes in a wrench test. r=gw
https://github.com/mozilla-firefox/firefox/commit/82188b14705e
https://hg.mozilla.org/integration/autoland/rev/1179286df233
Make the repetition iterator more NaN-proof. r=gfx-reviewers,lsalzman

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f1c032511858
https://hg.mozilla.org/integration/autoland/rev/f1852f70ec88
Revert "Bug 2020923, Bug 2019934 - Make the repetition iterator more NaN-proof. r=gfx-reviewers,lsalzman" for causing mochitests failures in browser_bug295977_autoscroll_overflow.js.

Comment 16

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitests failures in browser_bug295977_autoscroll_overflow.js.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/content/tests/browser/browser_bug295977_autoscroll_overflow.js | Failed: e should have scrolled vertically

Comment 17

[amarc]

please also address the failure in bug 2022950, and these:
https://treeherder.mozilla.org/logviewer?job_id=553265401&repo=autoland&task=bz9V4ujNRm6lGFqcseD5kw.0
https://treeherder.mozilla.org/logviewer?job_id=553265925&repo=autoland&task=OB6k1l1YR9SqpnlxKZI48A.0

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/09f373c97fe9
https://hg.mozilla.org/integration/autoland/rev/e370013c0832
Fix some repeated patterns incorrectly treated as opaque. r=gw
https://github.com/mozilla-firefox/firefox/commit/7c88c871becb
https://hg.mozilla.org/integration/autoland/rev/08190b1f849c
Avoid referring to clips across iframes in a wrench test. r=gw
https://github.com/mozilla-firefox/firefox/commit/05d2ee364a9b
https://hg.mozilla.org/integration/autoland/rev/c6154e13d42d
Make the repetition iterator more NaN-proof. r=gfx-reviewers,lsalzman
https://github.com/mozilla-firefox/firefox/commit/ec344ef3f2ef
https://hg.mozilla.org/integration/autoland/rev/022f24da497e
Disable the remaining use of non-quad linear gradients. r=gw

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2c7ef2d998bb
https://hg.mozilla.org/integration/autoland/rev/59c6f2fc146d
Revert "Bug 2020923, Bug 2019934 - Disable the remaining use of non-quad linear gradients. r=gw" for causing browser chrome failures at browser_bug295977_autoscroll_overflow.js

Comment 20

[Silaghi Andreea]

Backed out for causing browser chrome failures at browser_bug295977_autoscroll_overflow.js
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | toolkit/content/tests/browser/browser_bug295977_autoscroll_overflow.js | Failed: e should have scrolled vertically

Comment 21

[Nicolas Silva [:nical]]

Attachment: Bug 2020923 - Skip browser_bug295977_autoscroll_overflow.js on windows opt msix. r=#intermittent-reviewers

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fcebfd8d1b37
https://hg.mozilla.org/integration/autoland/rev/3a0b1199c663
Fix some repeated patterns incorrectly treated as opaque. r=gw
https://github.com/mozilla-firefox/firefox/commit/2d752a07832b
https://hg.mozilla.org/integration/autoland/rev/2fba0d11c3f5
Avoid referring to clips across iframes in a wrench test. r=gw
https://github.com/mozilla-firefox/firefox/commit/60578c17f272
https://hg.mozilla.org/integration/autoland/rev/3a6e56ff9509
Make the repetition iterator more NaN-proof. r=gfx-reviewers,lsalzman
https://github.com/mozilla-firefox/firefox/commit/800110818105
https://hg.mozilla.org/integration/autoland/rev/e96ee4a2ff9e
Disable the remaining use of non-quad linear gradients. r=gw
https://github.com/mozilla-firefox/firefox/commit/ea4167d4c780
https://hg.mozilla.org/integration/autoland/rev/420c5f80a6ca
Skip browser_bug295977_autoscroll_overflow.js on windows opt msix. r=intermittent-reviewers,ahal

Comment 23

[amarc]

https://hg.mozilla.org/mozilla-central/rev/3a0b1199c663
https://hg.mozilla.org/mozilla-central/rev/2fba0d11c3f5
https://hg.mozilla.org/mozilla-central/rev/3a6e56ff9509
https://hg.mozilla.org/mozilla-central/rev/e96ee4a2ff9e
https://hg.mozilla.org/mozilla-central/rev/420c5f80a6ca

Comment 24

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #22)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fcebfd8d1b37
https://hg.mozilla.org/integration/autoland/rev/3a0b1199c663
Fix some repeated patterns incorrectly treated as opaque. r=gw
https://github.com/mozilla-firefox/firefox/commit/2d752a07832b
https://hg.mozilla.org/integration/autoland/rev/2fba0d11c3f5
Avoid referring to clips across iframes in a wrench test. r=gw
https://github.com/mozilla-firefox/firefox/commit/60578c17f272
https://hg.mozilla.org/integration/autoland/rev/3a6e56ff9509
Make the repetition iterator more NaN-proof. r=gfx-reviewers,lsalzman
https://github.com/mozilla-firefox/firefox/commit/800110818105
https://hg.mozilla.org/integration/autoland/rev/e96ee4a2ff9e
Disable the remaining use of non-quad linear gradients. r=gw
https://github.com/mozilla-firefox/firefox/commit/ea4167d4c780
https://hg.mozilla.org/integration/autoland/rev/420c5f80a6ca
Skip browser_bug295977_autoscroll_overflow.js on windows opt msix.
r=intermittent-reviewers,ahal

Perfherder has detected a browsertime performance change from push 420c5f80a6ca3d16482b7be85a2457608ef4ebf3.

No action is required from the author; this comment is provided for informational purposes only.

Improvement	Test	Platform	Options	Absolute values [old vs new]	Performance Profiles
35%	yahoo-mail FirstVisualChange (doc)	macosx1470-64-shippable	cold fission webrender	283.44 ms -> 183.60 ms	Before/After
31%	yahoo-mail SpeedIndex (doc)	macosx1470-64-shippable	cold fission webrender	313.33 ms -> 216.98 ms	Before/After
28%	yahoo-mail ContentfulSpeedIndex (doc)	macosx1470-64-shippable	cold fission webrender	299.01 ms -> 215.85 ms	Before/After
20%	tumblr FirstVisualChange (doc)	macosx1470-64-shippable	cold fission webrender	460.39 ms -> 369.39 ms	Before/After
17%	bing-search ContentfulSpeedIndex (doc)	macosx1470-64-shippable	bytecode-cached cold fission webrender	442.11 ms -> 365.07 ms	Before/After
15%	bing-search ContentfulSpeedIndex (doc)	macosx1470-64-shippable	cold fission webrender	421.28 ms -> 359.79 ms	Before/After

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.