2020691 - Wire up "Delete Event" in new calendar event read dialog more menu

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, task, P3)

Description

[Martin Giger [:freaktechnik]]

Currently the menu items in the calendar read dialog are not hooked up to any action.

Comment 1

[Vineet Deo]

This can be split up in separate patches for each menu item action

Comment 2

[Toby Pilling [:tobyp]]

Using this as the first of those pieces rather than making it a meta...

The new calendar event read dialog includes a More actions (three-dot) menu containing actions that were available in the previous event dialog. Some of these actions are currently present in the UI but have not yet been wired up.

The Delete Event action currently does nothing when selected.

Implement the Delete Event action so that it provides the same underlying functionality as the previous event dialog, including any appropriate confirmation or handling required for the type of event being deleted.

Where the new calendar design provides updated UI or interaction patterns for deleting an event, those should be used instead of reproducing the old dialog's UI exactly.

Comment 3

[Toby Pilling [:tobyp]]

Service.prompt will suffice for the confirmation, which was requested by UX (the existing delete option which is accessible by right-clicking an event in the calendar view does not provide any confirmation prompt)

Comment 4

[Toby Pilling [:tobyp]]

Attachment: delete-repeating-event.png

Could you please confirm that we should use the existing confirmation UI and behaviour?

Single event - no confirmation (same as Google Calendar)
Repeating Event - prompt to delete single occurrence or all

Comment 6

[Vineet Deo]

Attachment: Bug 2020691 - Create new prompt dialog for deleting calendar events. r=#thunderbird-front-end-reviewers

How to Test

• Make sure new calendar dialog pref is set to true
• Open an event
• Open the menu and select "Delete"
• You should see the new styled dialog

This patch is just for the styling changes for the occurence version of the dialog, and doesn't contain any logic.

Comment 7

[Vineet Deo]

Attachment: Bug 2020691 - Hook up new calendar prompt dialog with logic and delete functionality. r=#thunderbird-front-end-reviewers

How to test

• Make sure calendar pref is set to true
• Create multiple events, some recurring some not
• Open the event in the new dialog and click delete
• When the event is just a single event, you should see a dialog styled like this https://zpl.io/EdwwqMY
• When the event is a recurring event, you should see a dialog styled like this https://zpl.io/NE44ZXk
• The radio actions should do as they show, deleting a single occurrence should do so, as well as deleting all events

Depends on D327335

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/be9d3bc2659b
Create new prompt dialog for deleting calendar events. r=klamping,tobyp
https://hg.mozilla.org/comm-central/rev/32087428ae05
Hook up new calendar prompt dialog with logic and delete functionality. r=klamping,tobyp

Comment 9

[Stephen King (:sking)]

Attachment: Bug 2020691 - Follow-up: Wrap nextDay column so we always have a valid column. r=#thunderbird-front-end-reviewers

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f793f2f86541
Follow-up: Wrap nextDay column so we always have a valid column. r=mkmelin

Comment 11

[Vineet Deo]

Reopening to add the condition where users have set the pref calendar.item.promptDelete to false.

Comment 12

[Vineet Deo]

Attachment: Bug 2020691 - Calendar Read Dialog: Don't show delete prompt if calendar.item.promptDelete is set to false. r=#thunderbird-front-end-reviewers

How to Test

• Set calendar.item.promptDelete to false and enable the new calendar read dialog in settings
• Create an event and a recurring event
• Deleting either should delete the occurrence

Comment 13

[Phabricator Automation]

Comment on attachment 9669121 [details]
Bug 2020691 - Calendar Read Dialog: Don't show delete prompt if calendar.item.promptDelete is set to false. r=#thunderbird-front-end-reviewers

Revision D337270 was moved to bug 2087332. Setting attachment 9669121 [details] to obsolete.

Comment 14

[Vineet Deo]

Moved the follow up bug to bug 2087332.