2082770 - Account Hub is not able to detect calendars in the latest Daily and Beta build (159.b and 160.0a)

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Attachment: Screenshot 2026-10-16 at 10.26.40.png

Affected versions

• 160.0a1(20261015104419)
• 159.0b2(20261013231314)

Non-affected versions

• 158.0(20261008005236)

Affected platforms

• Ubuntu 26
• macOS 27
• Win 11

Steps to reproduce

1. Launch TB with a fresh profile.
2. Login with valid credentials.

Expected result

• No errors are displayed in the error console.
• The Accounts Hub wizard discovers address books and calendars.

Actual result

• The accounts hub process freezes stuck for about 5 minutes with the loading animation, after that it returns that no calendars have been detected.

[CalICSProvider] Could not detect calendar using method attemptGet NS_ERROR_DOM_NETWORK_ERR: Connection error
    onStreamComplete resource:///modules/caldav/CalDavRequest.sys.mjs:483
CalICSProvider.sys.mjs:103:20
The resource at “https://www.thunderbird.net/en-US/” was blocked by OpaqueResponseBlocking. Reason: “after sniff: status code is not in allowed range”.
calendar: [CalICSProvider] Could not detect calendar using method attemptDAVLocation NS_ERROR_DOM_NETWORK_ERR: Connection error
    onStreamComplete resource:///modules/caldav/CalDavRequest.sys.mjs:483
CalICSProvider.sys.mjs:103:20
The resource at “https://www.thunderbird.net/en-US/” was blocked by OpaqueResponseBlocking. Reason: “after sniff: status code is not in allowed range”.
calendar: [CalICSProvider] Could not detect calendar using method attemptPut NS_ERROR_DOM_NETWORK_ERR: Connection error
    onStreamComplete resource:///modules/caldav/CalDavRequest.sys.mjs:483
CalICSProvider.sys.mjs:103:20

Notes

• This issue does not reproduce with 158.0.
• We manually went through recent builds and it seems that the issue was not present in 158.0b4 and 158.0b5, but started to be present starting with 159.0b1.
• This issue is a regression, relevant information below:
• The generated pushlog can be found here
• Screencast of the issue can be found here
  
• Last good is 2026.09.25 / First bad is 2026.09.27 (multiple build fails in comm-central as per attachment)
• The regressor could be bug 2020691 or bug 2052324.

2026-10-16T09:18:29.670000: ERROR : Unable to start the application (error: Failed to start the process: [Errno 86] Bad CPU type in executable: '/private/var/folders/l5/fxnd__qx39v3_t3jq03165_w0000gp/T/tmp84tnhp1f/Thunderbird Daily.app/Contents/MacOS/thunderbird')
2026-10-16T09:18:30.854000: DEBUG : Starting merge handling...
2026-10-16T09:18:30.854000: DEBUG : Using url: https://hg.mozilla.org/comm-central/json-pushes?changeset=2a6c5ae4a47607be8672826f5df685375910daaa&…
2026-10-16T09:18:30.854000: DEBUG : redo: attempt 1/3
2026-10-16T09:18:30.855000: DEBUG : redo: retry: calling _default_get with args: ('https://hg.mozilla.org/comm-central/json-pushes?changeset=2a6c5ae4a47607be8672826f5df685375910daaa&…, kwargs: {}, attempt #1
2026-10-16T09:18:30.856000: DEBUG : urllib3.connectionpool: Resetting dropped connection: hg.mozilla.org
2026-10-16T09:18:32.087000: DEBUG : urllib3.connectionpool: https://hg.mozilla.org:443 "GET /comm-central/json-pushes?changeset=2a6c5ae4a47607be8672826f5df685375910daaa&full=1 HTTP/1.1" 302 0
2026-10-16T09:18:32.904000: DEBUG : urllib3.connectionpool: https://hg-edge.mozilla.org:443 "GET /comm-central/json-pushes?changeset=2a6c5ae4a47607be8672826f5df685375910daaa&full=1 HTTP/1.1" 200 None
2026-10-16T09:18:32.910000: DEBUG : Found commit message:
Bug 2075724 - Follow-up: Add missing headers for ccov builds r=mkmelin

Differential Revision: https://phabricator.services.mozilla.com/D329363


2026-10-16T09:18:32.911000: DEBUG : Did not find a branch, checking all integration branches
2026-10-16T09:18:32.911000: INFO : The bisection is done.
2026-10-16T09:18:32.913000: INFO : Stopped

Comment 1

[Magnus Melin [:mkmelin]]

From bug 2052324.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 2082770 - Fix CalDAV calendar discovery for OAuth2 accounts in the Account Hub. r=edicharry,freaktechnik

Bug 2052324 moved the check for a granted CalDAV scope from the Account Hub
into CalDavProvider.detectCalendars, so that it would no longer stop Graph
calendar detection. It passed the detection location to
OAuth2Module.initFromHostname, but the location is a URL built from the email
domain, which does not map to an OAuth2 provider, so CalDAV detection returned
no calendars for every OAuth2 account.

Do the check in the Account Hub again, using the incoming server's hostname,
and skip only the CalDAV provider through a pre-detect filter when the scope
wasn't granted. Graph detection is unaffected, as only CalDAV is skipped.
lso always skip the ICS provider there: it only probes the URL it is
given, and the domain's website is never an ICS calendar.

The authMethod argument bug 2052324 added to detectCalendars is no longer
used, so remove it again.

Also pass the username to locationToUri in the CalDAV and ICS providers, so
an empty location falls back to the domain of the username as intended.

Comment 3

[Wayne Mery (:wsmwk)]

Great work finding the regression.

Setting tracking flags with version number Is great. But please avoid using "Trunk" as a version# for regressions. Set version to the earliest known regressed version#. Thanks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ae7aec68c1a9
Fix CalDAV calendar discovery for OAuth2 accounts in the Account Hub. r=edicharry

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9661907 [details]
Bug 2082770 - Fix CalDAV calendar discovery for OAuth2 accounts in the Account Hub. r=edicharry,freaktechnik

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Regression
• User impact if declined: CalDAV calendars not discovered
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): Complex system. But status que is totally broken so definitely needs uplift.
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: none

Comment 6

[Corey Bryant]

Comment on attachment 9661907 [details]
Bug 2082770 - Fix CalDAV calendar discovery for OAuth2 accounts in the Account Hub. r=edicharry,freaktechnik

[Triage Comment]
Approved for beta

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 159.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/ab52e770cca7