Closed Bug 2021451 Opened 8 months ago Closed 8 months ago

AssertedCast error: Cannot cast 4294967295 from uint32_t to int32_t: out of range

Categories

(Core :: WebRTC: Audio/Video, defect, P3)

defect

Tracking

()

RESOLVED FIXED
150 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr140 --- unaffected
firefox148 --- wontfix
firefox149 --- wontfix
firefox150 --- fixed

People

(Reporter: tsmith, Assigned: pehrsons)

References

(Blocks 1 open bug, Regression)

Details

(4 keywords, Whiteboard: [bugmon:bisected,confirmed])

Attachments

(1 file, 1 external file)

Attached file testcase.html —

Found while fuzzing m-c 20260219-64b3c91301e8 (--enable-debug --enable-fuzzing)

To reproduce via Grizzly Replay:

$ pip install fuzzfetch grizzly-framework --upgrade
$ python -m fuzzfetch -d --fuzzing -n firefox
$ python -m grizzly.replay.bugzilla ./firefox/firefox <bugid>

AssertedCast error: Cannot cast 4294967295 from uint32_t to int32_t: out of range

#0 0x7c5563cb32bc in MOZ_CrashSequence /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:237:3
#1 0x7c5563cb32bc in AssertedCast<int, unsigned int> /builds/worker/workspace/obj-build/dist/include/mozilla/Casting.h:238:5
#2 0x7c5563cb32bc in operator()<mozilla::AudioCodecConfig> /builds/worker/checkouts/gecko/dom/media/webrtc/libwebrtcglue/AudioConduit.cpp:362:26
#3 0x7c5563cb32bc in apply<(lambda at /builds/worker/checkouts/gecko/dom/media/webrtc/libwebrtcglue/AudioConduit.cpp:348:35)> /builds/worker/workspace/obj-build/dist/include/mozilla/Maybe.h:645:7
#4 0x7c5563cb32bc in mozilla::WebrtcAudioConduit::OnControlConfigChange() /builds/worker/checkouts/gecko/dom/media/webrtc/libwebrtcglue/AudioConduit.cpp:348:29
#5 0x7c55631027fa in mozilla::WatchManager<mozilla::dom::TextTrackCue>::PerCallbackWatcher::Notify()::'lambda'()::operator()() const /builds/worker/workspace/obj-build/dist/include/mozilla/StateWatching.h:265:38
#6 0x7c556310270c in mozilla::detail::RunnableFunction<mozilla::WatchManager<mozilla::dom::TextTrackCue>::PerCallbackWatcher::Notify()::'lambda'()>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:549:5
#7 0x7c555f09f88b in mozilla::SimpleTaskQueue::DrainTasks() /builds/worker/workspace/obj-build/dist/include/mozilla/TaskDispatcher.h:48:10
#8 0x7c555f09f991 in DrainDirectTasks /builds/worker/checkouts/gecko/xpcom/threads/TaskQueue.cpp:375:16
#9 0x7c555f09f991 in non-virtual thunk to mozilla::TaskQueue::DrainDirectTasks() /builds/worker/checkouts/gecko/xpcom/threads/TaskQueue.cpp:0:0
#10 0x7c555f0a2544 in MaybeDrainDirectTasks /builds/worker/workspace/obj-build/dist/include/mozilla/TaskDispatcher.h:247:41
#11 0x7c555f0a2544 in mozilla::AutoTaskDispatcher::TaskGroupRunnable::Run() /builds/worker/workspace/obj-build/dist/include/mozilla/TaskDispatcher.h:230:7
#12 0x7c555f09e860 in mozilla::TaskQueue::Runner::Run() /builds/worker/checkouts/gecko/xpcom/threads/TaskQueue.cpp:311:20
#13 0x7c555f0c542e in nsThreadPool::Run() /builds/worker/checkouts/gecko/xpcom/threads/nsThreadPool.cpp:446:14
#14 0x7c555f0bcc52 in nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1163:16
#15 0x7c555f0c26df in NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:467:10
#16 0x7c555fcba768 in mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:299:20
#17 0x7c555fc12991 in RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:366:3
#18 0x7c555fc12991 in MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:348:3
#19 0x7c555f0b885e in nsThread::ThreadFunc(void*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:373:10
#20 0x7c55709903ac in _pt_root /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:191:3
#21 0x7c5570a2cac2 in start_thread ./nptl/pthread_create.c:442:8

Verified bug as reproducible on mozilla-central 20260305215107-edcea1e99bb9.
The bug appears to have been introduced in the following build range:

Start: 9e06db4da20903f3daed4e3295ad8ac2f990984d (20250904082226)
End: 370f65867008f323af6579b15a4251e9b04531bc (20250904102234)
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9e06db4da20903f3daed4e3295ad8ac2f990984d&tochange=370f65867008f323af6579b15a4251e9b04531bc

Keywords: regression
Whiteboard: [bugmon:bisected,confirmed]
Regressed by: 1573726

Set release status flags based on info from the regressing bug 1573726

:pehrsons, since you are the author of the regressor, bug 1573726, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(apehrson)

So spec's type is unsigned long and libwebrtc uses int. In signaling we make it a uint32_t and it's the conversion from that to int that is bad.

Worst case here is a misinterpreted (negative) max bitrate. In libwebrtc it gets clamped to the codec's min and max bitrate meaning if JS sets a very high max bitrate, we end up using the codec's min bitrate. Could be worse.

Assignee: nobody → apehrson
Severity: -- → S3
Status: NEW → ASSIGNED
Component: WebRTC → WebRTC: Audio/Video
Flags: needinfo?(apehrson)
Priority: -- → P3
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch

Unable to reproduce bug 2021451 using build mozilla-central 20260219215206-64b3c91301e8. Without a baseline, bugmon is unable to analyze this bug.
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Keywords: bugmon
QA Whiteboard: [qa-triage-done-c151/b150]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: