202217 - [beos] nsWindow impl. does not support eBorderStyle attributes

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Paul]

BeOS's nsWindow impl. does not support the eBorderStyle attributes.  Patch to
follow.

Comment 1

[Paul]

Attachment: make nsWindow honor eBorderStyle attributes

Patch cleans up logic flow, removes duplicate code, and honors eBorderStyle
attributes

Comment 2

[Sergei Dolgov]

Paul, do you think that border-styles are unrelated to eWindowType_dialog ?

Comment 3

[Paul]

why do you ask?  the patch tests border styles for both dialogs and "normal"
windows.  Notice, there is no break after the dialog's case statement.

Comment 4

[Sergei Dolgov]

Asking in relation to bug http://bugzilla.mozilla.org/show_bug.cgi?id=202218.
I rather meant that border-style implementation may be bit different for those
cases, which allows (maybe) workaround bug 202218

Comment 5

[Sergei Dolgov]

One more notice.
IMHO, adding B_OUTLINE_RESIZE window flag if window is resizable fits well in
this bug/patch

Comment 6

[Paul]

From what I've seen of the GTK and Windows ports, they apply the same border
style information to both dialogs and normal windows, but, as I am not a GTK or
windows developer, I could be wrong.

And, I agree with the B_OUTLINE_RESIZE comment, and will post an updated patch.

Comment 7

[Paul]

Attachment: updated patch: B_OUTLINE_RESIZE, debug info

- Made default flags for all windows include B_OUTLINE_RESIZE
- Added debug information

Comment 8

[Paul]

Attachment: updated, so debug output is always on for debug builds

Updated to only debug output from StandardWindowCreate when flag is set.

Comment 9

[Paul]

Comment on attachment 121121 [details] [diff] [review]
updated, so debug output is always on for debug builds

Sergei, I would like to get this checked in, before starting to work on the
focus changes, since, that patch will include changes to this method as well.
Thanks.

Comment 10

[Sergei Dolgov]

Comment on attachment 121121 [details] [diff] [review]
updated, so debug output is always on for debug builds

r=[e-mail]

Ok. As there is lot of work to do on other things, lets go.
Hope we can to polish things in future in good tempo, if some minor problems
appear in realtion to this change.

Comment 11

[Paul]

this has been checked in.