[beos] customize toolbar window displays titlebar

RESOLVED WORKSFORME

Status

()

RESOLVED WORKSFORME
16 years ago
13 years ago

People

(Reporter: beos, Unassigned)

Tracking

({helpwanted})

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

16 years ago
I have a patch prepared for the BeOS widget library, that makes nsWindow under
BeOS honor the eBorderStyle attributes of a window.  I wrote the patch, in the
hopes that the "Customize Toolbar" window would be created w/o the title bar.

However, the title bar remains.  The eBorderStyle that is passed into the
nsWindow's create method is eBorderStyle_all, so, even with my patch applied,
the window still has a titlebar. 

I've searched for where and why this is happenning, but, I'm having trouble
finding the solution.
(Reporter)

Updated

16 years ago
Keywords: helpwanted
(Reporter)

Comment 1

16 years ago
Some addition comments:

Is it the intension of Phoenix that eWindowType_dialog has no titlebar, is not
resizable, etc.?  The reason I ask, is that the "Customize Toolbar" window is
created as a dialog, and, with a border style of eWindowStyle_default, which is,
according to nsIWidget.h:

  // whatever the OS wants... i.e. don't do anything
  eBorderStyle_default  = -1

But, obviously, that is not what I suspect is suposed to happen.  So, shouldn't
the border style for the custimize toolbar dialog be eBorderStyle_none instead?
 If so, where would this be defined?
(Reporter)

Comment 2

16 years ago
Setting to major, as, IMO, the customize toolbar item is fairly significant in
Firebird, and, with the way things work now, not only is it ugly, but completely
wrong.
Setting P1, since I would like to get this fixed ASAP.
Severity: normal → major
Priority: -- → P1

Comment 3

15 years ago
Taking QA Contact
QA Contact: asa → bugzilla
not major severity, please don't set priority on bugs, that is a assignee-set flag
Severity: major → normal
Priority: P1 → --
The customize toolbar window actually appears to use the function HideWindowChrome.

You need to implement this function on BeOS.

Comment 6

14 years ago
/* Hide window chrome (borders, buttons) for this widget. */

Which means we should override it and change style of the window where there is one.

Should be easy to do. 

Updated

14 years ago
Blocks: 266252

Comment 7

14 years ago
Implementing HideWindowChrome doesn't seem to do that. Maybe that's called in a
specific OS implementation?

Updated

13 years ago
Assignee: hyatt → nobody
QA Contact: bugzilla → toolbars

Updated

13 years ago
No longer blocks: 266252

Updated

13 years ago
Blocks: 311032

Comment 8

13 years ago
tqh,
in our case it needs changing BWindow look, did you try to do it?

Comment 9

13 years ago
Fixed by bug 296856.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.