2022527 - Remove the hack from bug 2007147

Status: ASSIGNED

(Firefox :: Address Bar, task, P3)

Description

[Dão Gottwald [:dao]]

Once bug 2014481 is fixed, we should remove the hack that bug 2007147 introduced. Alternatively, I guess we may want to look into doing what emilio suggested in bug 2007147 comment 7, unless Moritz had already tried that?

Comment 1

[Moritz Beier [:mbeier]]

Alternatively, I guess we may want to look into doing what emilio suggested in bug 2007147 comment 7, unless Moritz had already tried that?

I just tried it and it doesn't work either. I think the results panel is opened synchronously on focus, so the solutions are pretty much equivalent.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

FYI you should be able to do this now.

Comment 3

[Moritz Beier [:mbeier]]

Sorry for taking to long to get back, but the issue doesn't seem to be fully fixed yet. You can now select text even while switching display, but the selection always starts from the start (try here).

This causes test failures e.g. here.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Hmm, Masayuki was looking into persisting the DOM selection as well, which probably helps... Do you know of an ETA for that?

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

No, my queue is now full for web-compat issues and sec bugs...

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Moritz Beier [:mbeier] from comment #3)

Sorry for taking to long to get back, but the issue doesn't seem to be fully fixed yet. You can now select text even while switching display, but the selection always starts from the start (try here).

This symptom sounds like bug 2036298 which I've already fixed. How about the result of your patch with newer m-c?

Comment 7

[Moritz Beier [:mbeier]]

That part is working now and the test I mentioned passes now, thanks!

However, there seems to be another bug: toggling popover (changing display mode) of an ancestor in the popupshowing listener of a XUL popup causes it to not show. In practice, this causes the context menu to not open when the urlbar is open. I filed bug 2037468 and attached a test there.

Comment 8

[Moritz Beier [:mbeier]]

Emilio suggested to call hidePopover in a contextmenu event listener for now.

Comment 9

[Moritz Beier [:mbeier]]

Attachment: Bug 2022527 - Remove the hack from bug 2007147. r?dao

Changing the popupshowing listeners to contextmenu is necessary because one of them hides the view which calls hidePopover on the urlbar, preventing the context menu from showing because of bug 2037468. Using a contextmenu listener instead calls hidePopover before the contextmenu starts showing, avoiding the bug.