2023695 - Nova redesign for tab group menu

Status: ASSIGNED

(Firefox :: Tabbed Browser: Tab Groups, task, P1)

Description

[Stephen Thompson [:sthompson]]

UX spec: https://www.figma.com/design/XT0eDYh4RtbMNWaYQi0efM/Chrome-Sidebar-UX-Specifications--Sprint-1-?node-id=9631-131050&t=8JmJB8LIHAYiDTm9-0

This bug does not include the Smart Tab Groups parts of the tab group menu.

Notable changes:

• smaller header
• no separators
• color swatches move to the top and get restyled

There was some work to update the color swatches in bug 2023691, but based on the report in bug 2052177, this is not working correctly. The tabgroup-menu.js code builds the swatches once when it connects to the DOM. If you start the browser without Nova and then enable it, it will continue to use the pre-Nova tab group color tokens. The tab group color swatches in this menu should always use --tab-group-color-${colorCode} and --tab-group-color-${colorCode}-invert when Nova is disabled and always use --tab-group-${colorCode} when Nova is enabled.

Comment 2

[kpatenio]

Concerning the swatches failing to update on Nova pref change: it might have been fixed by Bug 2046942.

We no longer need a Nova pref check for var(--tab-group-${colorCode}), and --tab-group--color-${colorCode}-invert was swapped to--tab-group-${colorCode}-invert. I confirmed with a local build (Nightly 154) that the swatches now correctly update when we flip the pref.

Comment 3

[kpatenio]

Attachment: Bug 2023695 — redesign tab group menu for Nova