2023696 - Replace the desktop shortcut with the desktop launcher when Firefox is installed via the full installer

Status: VERIFIED FIXED

(Firefox :: Installer, task, P2)

Comment 1

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2023696 - Do not install the Desktop Launcher if the installation type is MSI r=#application-update-reviewers!,#browser-installer-reviewers!

Comment 2

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2023696 - If the installation type is full, only install the Desktop Launcher if /DesktopLauncher is passed r=#application-update-reviewers!,#browser-installer-reviewers!

Comment 3

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2023696 - Avoid duplicate desktop shortcuts in single-process updates r=#application-update-reviewers!,#browser-installer-reviewers!

Comment 4

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2023696 - Add helper functions to manage the enterprise policy flag file r=#application-update-reviewers!,#browser-installer-reviewers!

Comment 5

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2023696 - Add function to check if enterprise policies are set via distribution/policies.json r=#application-update-reviewers!,#browser-installer-reviewers!

Comment 6

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2023696 - Add function to check if enterprise policies are set via registry r=#application-update-reviewers!,#browser-installer-reviewers!

Comment 7

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2023696 - Add logic to install the Desktop Launcher to the updater r=#application-update-reviewers!,#browser-installer-reviewers!

Comment 8

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2023696 - Add metric to record the Desktop Launcher installation status with the full installer r=#application-update-reviewers!,#browser-installer-reviewers!

Comment 9

[Antonio Borondo [:aborondo] (he/him)]

Use cases

Scenario 1

Preconditions

• A user with administrative privileges is logged in.

Steps

• Install Firefox with the full installer in the standard location (C:\Program Files\Mozilla Firefox).
• Update Firefox.

Result

• Desktop shortcut is removed from C:\Users\Public\Desktop.
• Desktop Launcher is added into %USERPROFILE%\Desktop.

Scenario 2

Preconditions

• A user with administrative privileges is logged in.

Steps

• Install Firefox with the full installer in the standard location (C:\Program Files\Mozilla Firefox).

• Add distribution\policies.json into the installation directory with the following:

  {
      "policies": {
          "DisableAppUpdate": false,
          "ManualAppUpdateOnly": false
      }
  }
  

• Update Firefox.

Result

• Desktop shortcut isn't removed from C:\Users\Public\Desktop.
• Desktop Launcher isn't added into %USERPROFILE%\Desktop.

Scenario 3

Preconditions

• A user with administrative privileges is logged in.

Steps

• Install Firefox with the full installer in the standard location (C:\Program Files\Mozilla Firefox).
• Open registry and create the key HKCU\SOFTWARE\Policies\Mozilla\Firefox\Test.
• Update Firefox.

Result

• Desktop shortcut isn't removed from C:\Users\Public\Desktop.
• Desktop Launcher isn't added into %USERPROFILE%\Desktop.

Scenario 4

Preconditions

• A user with administrative privileges is logged in.

Steps

• Install Firefox with the full installer in %USERPROFILE%\AppData\Local\Firefox.
• Update Firefox.

Result

• Desktop shortcut is removed from C:\Users\Public\Desktop.
• Desktop Launcher is added into %USERPROFILE%\Desktop.

Scenario 5

Preconditions

• A user without administrative privileges is logged in.

Steps

• Install Firefox with the full installer.
• Click on Yes in the UAC prompt.
• Custom installation in C:\Program Files\Firefox Nightly\.
• Update Firefox.

Result

• Desktop shortcut is removed from C:\Users\Public\Desktop.
• Desktop Launcher is added into %USERPROFILE%\Desktop.

Scenario 6

Preconditions

• A user without administrative privileges is logged in.

Steps

• Install Firefox with the full installer.
• Click on Yes in the UAC prompt.
• Custom installation in C:\Users\<CURRENT_USER>\AppData\Local\Firefox Nightly\.
• Update Firefox.

Result

• Desktop shortcut isn't removed from C:\Users\Public\Desktop.
• Desktop Launcher isn't added into %USERPROFILE%\Desktop.

Scenario 7

Preconditions

• A user without administrative privileges is logged in.

Steps

• Install Firefox with the full installer.
• Click on No in the UAC prompt.
• Custom installation in C:\Users\<CURRENT_USER>\AppData\Local\Firefox Nightly\.
• Update Firefox.

Result

• Desktop shortcut is removed from %USERPROFILE%\Desktop.
• Desktop Launcher is added into %USERPROFILE%\Desktop.

Comment 10

[Mike Kaply [:mkaply]]

We should also make sure none of this happens with the ESR at all.

Comment 11

[Antonio Borondo [:aborondo] (he/him)]

(In reply to Mike Kaply [:mkaply] from comment #10)

We should also make sure none of this happens with the ESR at all.

This won't happen if there's an enterprise policy in distribution/policies.json or in the registry (HKLM or HKCU), as we discussed in this Slack thread. Is that ok?

Comment 12

[Mike Kaply [:mkaply]]

This won't happen if there's an enterprise policy in distribution/policies.json or in the registry (HKLM or HKCU), as we discussed in this Slack thread. Is that ok?

This won't cover ESR where we probably just shouldn't do this. Do we have any ESR checks in the installer today?

Comment 13

[Antonio Borondo [:aborondo] (he/him)]

(In reply to Mike Kaply [:mkaply] from comment #12)

Do we have any ESR checks in the installer today?

We don't. We need to add that check in the installer.

Comment 14

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2023696 - Do not install the Desktop Launcher if the update channel is ESR r=#application-update-reviewers!,#browser-installer-reviewers!

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c210ca67972d
https://hg.mozilla.org/integration/autoland/rev/02ec707791d0
Do not install the Desktop Launcher if the installation type is MSI r=cdupuis,browser-installer-reviewers,application-update-reviewers
https://github.com/mozilla-firefox/firefox/commit/87f3dd7d54a3
https://hg.mozilla.org/integration/autoland/rev/dfa50c61416a
If the installation type is full, only install the Desktop Launcher if /DesktopLauncher is passed r=application-update-reviewers,browser-installer-reviewers,cdupuis
https://github.com/mozilla-firefox/firefox/commit/4c41a5cbe80d
https://hg.mozilla.org/integration/autoland/rev/d025ae515a3f
Avoid duplicate desktop shortcuts in single-process updates r=application-update-reviewers,browser-installer-reviewers,cdupuis
https://github.com/mozilla-firefox/firefox/commit/07505173403c
https://hg.mozilla.org/integration/autoland/rev/dd256a402eb5
Add helper functions to manage the enterprise policy flag file r=application-update-reviewers,browser-installer-reviewers,cdupuis
https://github.com/mozilla-firefox/firefox/commit/d6d757d2aebf
https://hg.mozilla.org/integration/autoland/rev/a97d31341c6d
Add function to check if enterprise policies are set via distribution/policies.json r=application-update-reviewers,browser-installer-reviewers,cdupuis
https://github.com/mozilla-firefox/firefox/commit/ed0cff9ed3cd
https://hg.mozilla.org/integration/autoland/rev/92d03a547896
Add function to check if enterprise policies are set via registry r=application-update-reviewers,browser-installer-reviewers,cdupuis
https://github.com/mozilla-firefox/firefox/commit/b6ffe2da7342
https://hg.mozilla.org/integration/autoland/rev/0ef261d60f47
Add logic to install the Desktop Launcher to the updater r=application-update-reviewers,browser-installer-reviewers,cdupuis
https://github.com/mozilla-firefox/firefox/commit/83e553906371
https://hg.mozilla.org/integration/autoland/rev/f494d7d65c10
Add metric to record the Desktop Launcher installation status with the full installer r=application-update-reviewers,browser-installer-reviewers,cdupuis
https://github.com/mozilla-firefox/firefox/commit/94d765157e6a
https://hg.mozilla.org/integration/autoland/rev/98bb6f38af76
Do not install the Desktop Launcher if the update channel is ESR r=application-update-reviewers,browser-installer-reviewers,cdupuis

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/83a42233cd93
https://hg.mozilla.org/integration/autoland/rev/fe840f9fad3a
Revert "Bug 2023696 - Do not install the Desktop Launcher if the update channel is ESR r=application-update-reviewers,browser-installer-reviewers,cdupuis" for causing xpc failures @marAppApplyUpdateAppBinInUseStageSuccess_win.js.

Comment 17

[agoloman]

Backed out for causing xpc failures @marAppApplyUpdateAppBinInUseStageSuccess_win.js.

• Backout link
• Push with failures
• Failure Log

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/56c928f179a8
https://hg.mozilla.org/integration/autoland/rev/9781430e0d97
Do not install the Desktop Launcher if the installation type is MSI r=cdupuis,browser-installer-reviewers,application-update-reviewers
https://github.com/mozilla-firefox/firefox/commit/4aa5b82aa640
https://hg.mozilla.org/integration/autoland/rev/1fb5994ddecf
If the installation type is full, only install the Desktop Launcher if /DesktopLauncher is passed r=application-update-reviewers,browser-installer-reviewers,cdupuis
https://github.com/mozilla-firefox/firefox/commit/7d46073d4df6
https://hg.mozilla.org/integration/autoland/rev/9a74f28e0670
Avoid duplicate desktop shortcuts in single-process updates r=application-update-reviewers,browser-installer-reviewers,cdupuis
https://github.com/mozilla-firefox/firefox/commit/570912e4dce6
https://hg.mozilla.org/integration/autoland/rev/f24676d76365
Add helper functions to manage the enterprise policy flag file r=application-update-reviewers,browser-installer-reviewers,cdupuis
https://github.com/mozilla-firefox/firefox/commit/7dc509a9b82b
https://hg.mozilla.org/integration/autoland/rev/8890eca23873
Add function to check if enterprise policies are set via distribution/policies.json r=application-update-reviewers,browser-installer-reviewers,cdupuis
https://github.com/mozilla-firefox/firefox/commit/0c4aad1a1ac9
https://hg.mozilla.org/integration/autoland/rev/4c326c61eaf3
Add function to check if enterprise policies are set via registry r=application-update-reviewers,browser-installer-reviewers,cdupuis
https://github.com/mozilla-firefox/firefox/commit/3a988195fdfa
https://hg.mozilla.org/integration/autoland/rev/0f6b80814ae7
Add logic to install the Desktop Launcher to the updater r=application-update-reviewers,browser-installer-reviewers,cdupuis
https://github.com/mozilla-firefox/firefox/commit/e08f061841e9
https://hg.mozilla.org/integration/autoland/rev/fac29c254a34
Add metric to record the Desktop Launcher installation status with the full installer r=application-update-reviewers,browser-installer-reviewers,cdupuis
https://github.com/mozilla-firefox/firefox/commit/a38f959d5730
https://hg.mozilla.org/integration/autoland/rev/2c44b1f7d424
Do not install the Desktop Launcher if the update channel is ESR r=application-update-reviewers,browser-installer-reviewers,cdupuis

Comment 19

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2023696 - Do not install the Desktop Launcher if the installation type is MSI

Original Revision: https://phabricator.services.mozilla.com/D288528

Comment 20

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2023696 - If the installation type is full, only install the Desktop Launcher if /DesktopLauncher is passed

Original Revision: https://phabricator.services.mozilla.com/D293855

Comment 21

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2023696 - Avoid duplicate desktop shortcuts in single-process updates

Original Revision: https://phabricator.services.mozilla.com/D293856

Comment 22

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2023696 - Add helper functions to manage the enterprise policy flag file

Original Revision: https://phabricator.services.mozilla.com/D293857

Comment 23

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2023696 - Add function to check if enterprise policies are set via distribution/policies.json

Original Revision: https://phabricator.services.mozilla.com/D293858

Comment 24

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2023696 - Add function to check if enterprise policies are set via registry

Original Revision: https://phabricator.services.mozilla.com/D293859

Comment 25

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2023696 - Add logic to install the Desktop Launcher to the updater

Original Revision: https://phabricator.services.mozilla.com/D293860

Comment 26

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2023696 - Add metric to record the Desktop Launcher installation status with the full installer

Original Revision: https://phabricator.services.mozilla.com/D293861

Comment 27

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Product requires the changes to be included in Fx151.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: These changes will replace the existing desktop shortcut with the Desktop Launcher during Firefox updates, but only for installations performed using the full installer and not managed by enterprise policies.
• String changes made/needed?: No.
• Is Android affected?: no

Comment 28

[Antonio Borondo [:aborondo] (he/him)]

Attachment: Bug 2023696 - Do not install the Desktop Launcher if the update channel is ESR

Original Revision: https://phabricator.services.mozilla.com/D294433

Comment 29

[BMO Github Automation]

Authored by https://github.com/antonioborondo
https://github.com/mozilla/enterprise-firefox/commit/c210ca67972d465f63c7527966d46fe34fe4dd2a
[enterprise-main] Bug 2023696 - Do not install the Desktop Launcher if the installation type is MSI r=cdupuis,browser-installer-reviewers,application-update-reviewers

Authored by https://github.com/antonioborondo
https://github.com/mozilla/enterprise-firefox/commit/87f3dd7d54a36f9fdbb5603dce55be2c86c94f20
[enterprise-main] Bug 2023696 - If the installation type is full, only install the Desktop Launcher if /DesktopLauncher is passed r=application-update-reviewers,browser-installer-reviewers,cdupuis

Authored by https://github.com/antonioborondo
https://github.com/mozilla/enterprise-firefox/commit/4c41a5cbe80d00ed584b20e7be96b5499490f5ce
[enterprise-main] Bug 2023696 - Avoid duplicate desktop shortcuts in single-process updates r=application-update-reviewers,browser-installer-reviewers,cdupuis

Authored by https://github.com/antonioborondo
https://github.com/mozilla/enterprise-firefox/commit/07505173403c67608a3ec1d88882015018f79651
[enterprise-main] Bug 2023696 - Add helper functions to manage the enterprise policy flag file r=application-update-reviewers,browser-installer-reviewers,cdupuis

Authored by https://github.com/antonioborondo
https://github.com/mozilla/enterprise-firefox/commit/d6d757d2aebf42078876264f485fd3f4dc0b06e4
[enterprise-main] Bug 2023696 - Add function to check if enterprise policies are set via distribution/policies.json r=application-update-reviewers,browser-installer-reviewers,cdupuis

Authored by https://github.com/antonioborondo
https://github.com/mozilla/enterprise-firefox/commit/ed0cff9ed3cd2db6cc2288a6b75588a159a6a9ed
[enterprise-main] Bug 2023696 - Add function to check if enterprise policies are set via registry r=application-update-reviewers,browser-installer-reviewers,cdupuis

Authored by https://github.com/antonioborondo
https://github.com/mozilla/enterprise-firefox/commit/b6ffe2da734276b9e91db218ec0815f9f3aa9e06
[enterprise-main] Bug 2023696 - Add logic to install the Desktop Launcher to the updater r=application-update-reviewers,browser-installer-reviewers,cdupuis

Authored by https://github.com/antonioborondo
https://github.com/mozilla/enterprise-firefox/commit/83e553906371d4e771441b478e0044da9b1fdc28
[enterprise-main] Bug 2023696 - Add metric to record the Desktop Launcher installation status with the full installer r=application-update-reviewers,browser-installer-reviewers,cdupuis

Authored by https://github.com/antonioborondo
https://github.com/mozilla/enterprise-firefox/commit/94d765157e6a440cd52be0bbf01b69b7e01fd1c2
[enterprise-main] Bug 2023696 - Do not install the Desktop Launcher if the update channel is ESR r=application-update-reviewers,browser-installer-reviewers,cdupuis

Authored by agoloman
https://github.com/mozilla/enterprise-firefox/commit/83a42233cd9324a47ee1658558cc9a54df62ace2
[enterprise-main] Revert "Bug 2023696 - Do not install the Desktop Launcher if the update channel is ESR r=application-update-reviewers,browser-installer-reviewers,cdupuis" for causing xpc failures @marAppApplyUpdateAppBinInUseStageSuccess_win.js.

Comment 30

[amarc]

https://hg.mozilla.org/mozilla-central/rev/9781430e0d97
https://hg.mozilla.org/mozilla-central/rev/1fb5994ddecf
https://hg.mozilla.org/mozilla-central/rev/9a74f28e0670
https://hg.mozilla.org/mozilla-central/rev/f24676d76365
https://hg.mozilla.org/mozilla-central/rev/8890eca23873
https://hg.mozilla.org/mozilla-central/rev/4c326c61eaf3
https://hg.mozilla.org/mozilla-central/rev/0f6b80814ae7
https://hg.mozilla.org/mozilla-central/rev/fac29c254a34
https://hg.mozilla.org/mozilla-central/rev/2c44b1f7d424

Comment 31

[Antonio Borondo [:aborondo] (he/him)]

To verify the changes, you need a version of Firefox installed using the full installer that includes the changes, as well as a newer version available to update to, since it's during the update process that the desktop shortcut is replaced by the Desktop Launcher.

All the use cases are collected in Comment #9 and were verified in Nightly.

Comment 32

[Donal Meehan [:dmeehan]]

For a trace in the bug, this is pending QA validation and nightly bake time before uplifting.
Current status: investigating problems found by QA testing Comment 9

Comment 33

[Bogdan Maris, Desktop Test Engineering]

We are in the process of testing this on Nightly 152, will come back with an update as soon as we'll finished the testing. So far we found bug 2035214.

Comment 34

[Bogdan Maris, Desktop Test Engineering]

We finished testing this on both Windows 10 and Windows 11 using Nightly 152. We used the scenarios from comment 9 as a testing reference along other scenarios that we thought about. We did found a new issue bug 2035758 which is related to Scenario 5 from comment 9.
Except from the new issue we verified the previous issue found bug 2035214 as fixed.

Note:

• If we will end up uplifting this to 151 we'll have to uplift the fixes from the bugs that we found as well.

Comment 35

[Antonio Borondo [:aborondo] (he/him)]

I've updated the use cases and closed Bug 2035758 since it's correct. If no more issues have been found, the ticket is ready for uplift.

Thanks, Bogdan and Monica, for the extra effort in testing all of this!

Comment 36

[Bogdan Maris, Desktop Test Engineering]

(In reply to Antonio Borondo [:aborondo] from comment #35)

I've updated the use cases and closed Bug 2035758 since it's correct. If no more issues have been found, the ticket is ready for uplift.

No more issues from us. The extra scenarios added were already tested by us and the results are the same as from comment 9. Good to go from our end.

Comment 37

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/383b35436e5e
https://hg.mozilla.org/releases/mozilla-beta/rev/1a4ba08c05ee
https://github.com/mozilla-firefox/firefox/commit/8b39aa5a29fc
https://hg.mozilla.org/releases/mozilla-beta/rev/e758be697bda
https://github.com/mozilla-firefox/firefox/commit/cd10079d0575
https://hg.mozilla.org/releases/mozilla-beta/rev/ce9b826b076c
https://github.com/mozilla-firefox/firefox/commit/3ba1fbaa3908
https://hg.mozilla.org/releases/mozilla-beta/rev/d5f341c0f479
https://github.com/mozilla-firefox/firefox/commit/2b3715735b2f
https://hg.mozilla.org/releases/mozilla-beta/rev/8e7c0495fd4c
https://github.com/mozilla-firefox/firefox/commit/f3568cd3d2dc
https://hg.mozilla.org/releases/mozilla-beta/rev/129d731a7f28
https://github.com/mozilla-firefox/firefox/commit/f0ba8eea3542
https://hg.mozilla.org/releases/mozilla-beta/rev/4d68ae83953c
https://github.com/mozilla-firefox/firefox/commit/61c1f51c6003
https://hg.mozilla.org/releases/mozilla-beta/rev/2e9aa6371f8c
https://github.com/mozilla-firefox/firefox/commit/b5f21a97ee48
https://hg.mozilla.org/releases/mozilla-beta/rev/73e596adce6b

Comment 38

[Bogdan Maris, Desktop Test Engineering]

Sorry for being a bit late. We finished testing this on both Windows 10 and Windows 11 using Firefox 151 builds (beta 9 update to beta 10) on both Windows 10 and Windows 11 and we did not found any new issue.