2055041 - Use an environment variable to replace the '/DesktopLauncher' postupdater command-line argument

Status: RESOLVED INVALID

(Toolkit :: Application Update, task)

Description

[Duncan McIntosh [:dmcintosh]]

The command-line argument passed to the updater is specified in update_append.ini:

; ExeArg is the argument to pass to the PostUpdateWin exe
ExeArg=/PostUpdate

In bug 2023696, we started passing a new command-line argument /DesktopLauncher alongside /PostUpdate, but arguably we shouldn't be stepping on update_append.ini's metaphorical toes. I thought this would be really easy, quick pre-commit on my bug 2030812 stack, but it's not, so this bug will have the changes to do that. Then bug 2030812 can 'just' add a new environment variable.

Comment 1

[Duncan McIntosh [:dmcintosh]]

Actually, more of an updater issue, let's move it over.

Comment 2

[Duncan McIntosh [:dmcintosh]]

Attachment: Bug 2055041 - Pre: Add desktop_launcher_helpers.nsh to TEST_STUB_INSTALLER_DEPS. r=#browser-installer-reviewers!,aborondo

Comment 3

[Duncan McIntosh [:dmcintosh]]

Attachment: Bug 2055041 - Pass a MOZ_INSTALL_DESKTOP_LAUNCHER environment variable instead of /DesktopLauncher command line argument. r=#application-update-reviewers!,aborondo

Comment 4

[Duncan McIntosh [:dmcintosh]]

Attachment: WIP: Bug 2055041 - Post: Add tests that MOZ_INSTALL_DESKTOP_LAUNCHER is set at appropriate times. r=#application-update-reviewers,aborondo

Comment 5

[Duncan McIntosh [:dmcintosh]]

Attachment: Bug 2055041 - Pre: Add desktop_launcher_helpers.nsh to TEST_STUB_INSTALLER_DEPS. r=#browser-installer-reviewers!,aborondo

Comment 6

[Duncan McIntosh [:dmcintosh]]

Attachment: Bug 2055041 - Pass a MOZ_INSTALL_DESKTOP_LAUNCHER environment variable instead of /DesktopLauncher command line argument. r=#application-update-reviewers!,aborondo

Comment 7

[Duncan McIntosh [:dmcintosh]]

Attachment: WIP: Bug 2055041 - Post: Add tests that MOZ_INSTALL_DESKTOP_LAUNCHER is set at appropriate times. r=#application-update-reviewers,aborondo

Comment 8

[Duncan McIntosh [:dmcintosh]]

We've concluded that using a command-line argument makes sense, so no migration is needed.

Comment 9

[Phabricator Automation]

Comment on attachment 9608971 [details]
Bug 2055041 - Pre: Add desktop_launcher_helpers.nsh to TEST_STUB_INSTALLER_DEPS. r=#browser-installer-reviewers!,aborondo

Revision D312155 was moved to bug 2030812. Setting attachment 9608971 [details] to obsolete.