2023779 - "Recently Closed Tabs" menu items display "undefined" in the tooltip

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[Sam Johnson]

In the "Recently Closed Tabs" menu, when accessed via the menu bar or the app menu, hovering items shows a tooltip that says "undefined". In addition, in the "Recently Closed Windows" menu, when accessed via the menu bar, hovering items shows a tooltip that says "null". However, accessing the "Recently Closed Windows" menu from the app menu does show a proper tooltip.

The regressing bug always sets tooltiptext for items in these menus, but the value can be null or undefined, which ends up displaying in the tooltip to the user. It seems that it was intentionally made optional, so I'm updating the logic to not set any tooltiptext if none was provided.

Comment 1

[Sam Johnson]

Attachment: Bug 2023779 - Fix "undefined" and "null" tooltips within recently closed tabs and windows menus. r?#sessionstore-reviewers

The regressing bug always sets tooltiptext for items in these menus, but the value can be null or undefined, which ends up displaying in the tooltip to the user. It seems that it was intentionally made optional, so I'm updating the logic to not set any tooltiptext if none was provided.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1985619

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fc3f9306c65c
https://hg.mozilla.org/integration/autoland/rev/8c775d7f00ee
Fix "undefined" and "null" tooltips within recently closed tabs and windows menus. r=sessionstore-reviewers,sfoster

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/8c775d7f00ee

Comment 6

[Dana Lucaci, Desktop QA]

Reproduced with Firefox 150.0a1 (2026-03-16) on macOS 15 ARM.
Verified as fixed with Firefox 151.0a1 (20260326080630) and Firefox 150.0b1 (20260325090410) on macOS 15 ARM, Windows 10 and Ubuntu 22.04.