2023886 - Port normal borders from brush to quads

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Nicolas Silva [:nical]]

Should be fairly mechanical again, mostly reorganizing the code and replacing uses of the image brush shader with ps_quad_textured.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 2023886 - Move use_legacy_path out of PrimitiveInstanceKind. r=gw

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 2023886 - Move the border preparation code from prepare.rs to border.rs. r=gw

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 2023886 - Port the normal border code path from brush to quad. r=gw

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/22e42a889e98
https://hg.mozilla.org/integration/autoland/rev/97640fb65015
Move use_legacy_path out of PrimitiveInstanceKind. r=gw
https://github.com/mozilla-firefox/firefox/commit/58dda8d7ac6a
https://hg.mozilla.org/integration/autoland/rev/999e2de8cff5
Move the border preparation code from prepare.rs to border.rs. r=gw

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/97640fb65015
https://hg.mozilla.org/mozilla-central/rev/999e2de8cff5

Comment 6

[Nicolas Silva [:nical]]

Attachment: Bug 2023886 - Port the normal border code path from brush to quad. r=gw

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ba53dd42de44
https://hg.mozilla.org/integration/autoland/rev/5b2f983d0b91
Port the normal border code path from brush to quad. r=gw

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/00f7a79d8d39
https://hg.mozilla.org/integration/autoland/rev/60ac97967bc2
Revert "Bug 2023886 - Port the normal border code path from brush to quad. r=gw" for causinf reftests failures

Comment 9

[Silaghi Andreea]

Backed out for causing reftests failures
Backout Link
Push with failures
wr
Failure Log
Failure line REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/bugs/935056-1.html == layout/reftests/bugs/935056-1-ref.html | image comparison, max difference: 53, number of differing pixels: 8
TEST-UNEXPECTED-FAIL | /css/css-flexbox/flexbox-align-self-vert-002.xhtml | Testing http://web-platform.test:8000/css/css-flexbox/flexbox-align-self-vert-002.xhtml == http://web-platform.test:8000/css/css-flexbox/flexbox-align-self-vert-002-ref.xhtml

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/db0e8b6a1255
https://hg.mozilla.org/integration/autoland/rev/cd53d0298277
Port the normal border code path from brush to quad. r=gw

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3966f01c3d42
https://hg.mozilla.org/integration/autoland/rev/b7a4436d7067
Revert "Bug 2023886 - Port the normal border code path from brush to quad. r=gw" for causing reftest failures

Comment 12

[Sandor Molnar[:smolnar]]

Backed out for causing reftest failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/b7a4436d706777c99cddcfcd1d8c8595c1015bd5

Push with failures

Failures log ->REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/bugs/1133905-5-v-rtl.html == layout/reftests/bugs/1133905-ref-v-rtl.html | image comparison, max difference: 53, number of differing pixels: 8

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/da4735559860
https://hg.mozilla.org/integration/autoland/rev/8ec0e8cfb8bd
Port the normal border code path from brush to quad. r=gw

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b5f63e2223c5
https://hg.mozilla.org/integration/autoland/rev/deb0da0deca3
Revert "Bug 2023886 - Port the normal border code path from brush to quad. r=gw" for causing Wrench bustages.

Comment 15

[Atila Butkovits]

Backed out for causing Wrench bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/deb0da0deca3

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=8ec0e8cfb8bd331e471f49d59d71c6c71b649363&selectedTaskRun=SEjZ-QSQTzqPWZh5E2QkwA.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=570682670&repo=autoland&task=SEjZ-QSQTzqPWZh5E2QkwA.0&lineNumber=726
https://treeherder.mozilla.org/logviewer?job_id=570710007&repo=autoland&task=A7EIe0mpTI2hlJJmXVhT3g.0&lineNumber=8068
https://treeherder.mozilla.org/logviewer?job_id=570709098&repo=autoland&task=e6m3aNoCQ3Cv7S4yHTpn_g.0&lineNumber=5123

Comment 16

[BMO Github Automation]

Authored by https://github.com/nical
https://github.com/mozilla/enterprise-firefox/commit/ba53dd42de4441758ea0f20f9ce59df68c9d385a
[enterprise-main] Bug 2023886 - Port the normal border code path from brush to quad. r=gw

Authored by Silaghi
https://github.com/mozilla/enterprise-firefox/commit/00f7a79d8d397bb11e9178ccddfed18d90d46062
[enterprise-main] Revert "Bug 2023886 - Port the normal border code path from brush to quad. r=gw" for causinf reftests failures

Authored by https://github.com/nical
https://github.com/mozilla/enterprise-firefox/commit/db0e8b6a125519d02adf0bc8f22ad3aa18747014
[enterprise-main] Bug 2023886 - Port the normal border code path from brush to quad. r=gw

Authored by https://github.com/smolnar-sheriff
https://github.com/mozilla/enterprise-firefox/commit/3966f01c3d42c11c44a1e18acd343d04bbb1d671
[enterprise-main] Revert "Bug 2023886 - Port the normal border code path from brush to quad. r=gw" for causing reftest failures

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5cc53a52a62e
https://hg.mozilla.org/integration/autoland/rev/f291dbf8337b
Port the normal border code path from brush to quad. r=gw

Comment 18

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f291dbf8337b

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/debc92f5b06f
https://hg.mozilla.org/integration/autoland/rev/63ea147bf1a2
Revert "Bug 2023886 - Port the normal border code path from brush to quad. r=gw" for causing bc failures @ browser_dynamic_frames.js

Comment 21

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_dynamic_frames.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/63ea147bf1a2c1cdf3c00c0e89428b68dc96ab44

Push with failures

Failures log ->TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_dynamic_frames.js | Test timed out

Comment 22

[Nicolas Silva [:nical]]

(In reply to Sandor Molnar[:smolnar] from comment #21)

Backed out for causing bc failures @ browser_dynamic_frames.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/63ea147bf1a2c1cdf3c00c0e89428b68dc96ab44

Push with failures

Failures log ->TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_dynamic_frames.js | Test timed out

It appears that this test already times out fairly frequently without my patches from a look at autoland. So I'll re-land as-is.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3c16aee41958
https://hg.mozilla.org/integration/autoland/rev/bdb88e138ab8
Port the normal border code path from brush to quad. r=gw

Comment 24

[Norisz Fay [:noriszfay]]

Backout was merged into central: https://hg-edge.mozilla.org/mozilla-central/rev/63ea147bf1a2

Comment 25

[amarc]

https://hg.mozilla.org/mozilla-central/rev/bdb88e138ab8